From: "J. Bruce Fields" <bfields@fieldses.org>
To: Michal Marek <mmarek@suse.cz>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: Fix tar-pkg with relative $(objtree)
Date: Wed, 18 Jun 2014 11:29:12 -0400 [thread overview]
Message-ID: <20140618152912.GD17790@fieldses.org> (raw)
In-Reply-To: <1403101583-15275-1-git-send-email-mmarek@suse.cz>
On Wed, Jun 18, 2014 at 04:26:23PM +0200, Michal Marek wrote:
> Commit 7e1c0477 (kbuild: Use relative path for $(objtree)) assumes that
> the build process does not change its working directory. make tar-pkg
> was a couterexample, fix this by changing directory only for the tar
> command and not for the whole script, which at one point references the
> now relative $(objtree).
Works for me, thanks.--b.
>
> Reported-by: "J. Bruce Fields" <bfields@fieldses.org>
> Signed-off-by: Michal Marek <mmarek@suse.cz>
> ---
> scripts/package/buildtar | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/scripts/package/buildtar b/scripts/package/buildtar
> index 995c1ea..e046bff 100644
> --- a/scripts/package/buildtar
> +++ b/scripts/package/buildtar
> @@ -125,12 +125,11 @@ esac
> # Create the tarball
> #
> (
> - cd "${tmpdir}"
> opts=
> if tar --owner=root --group=root --help >/dev/null 2>&1; then
> opts="--owner=root --group=root"
> fi
> - tar cf - boot/* lib/* $opts | ${compress} > "${tarball}${file_ext}"
> + tar cf - -C "$tmpdir" boot/ lib/ $opts | ${compress} > "${tarball}${file_ext}"
> )
>
> echo "Tarball successfully created in ${tarball}${file_ext}"
> --
> 1.9.2
>
next prev parent reply other threads:[~2014-06-18 15:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 22:38 relative objtree change broke tar builds? J. Bruce Fields
2014-06-18 9:06 ` Michal Marek
2014-06-18 12:20 ` J. Bruce Fields
2014-06-18 12:33 ` Michal Marek
2014-06-18 13:14 ` J. Bruce Fields
2014-06-18 15:58 ` Randy Dunlap
2014-06-18 19:47 ` Michal Marek
2014-06-18 19:52 ` Sam Ravnborg
2014-06-18 21:13 ` Randy Dunlap
2014-07-04 21:37 ` Michal Marek
2014-07-04 21:40 ` Randy Dunlap
2014-07-07 1:04 ` Randy Dunlap
2014-06-18 21:20 ` Randy Dunlap
2014-06-19 1:21 ` Ken Moffat
2014-07-04 21:42 ` Michal Marek
2014-06-18 14:26 ` [PATCH] kbuild: Fix tar-pkg with relative $(objtree) Michal Marek
2014-06-18 15:29 ` J. Bruce Fields [this message]
2014-06-18 15:34 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140618152912.GD17790@fieldses.org \
--to=bfields@fieldses.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).