From: Matt Porter <mporter@linaro.org>
To: Graham Williams <graham.williams@linaro.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Lee Jones <lee.jones@linaro.org>,
Dave Jones <davej@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: bcm590xx: fix vbus name
Date: Wed, 18 Jun 2014 16:32:34 -0400 [thread overview]
Message-ID: <20140618203234.GQ4173@beef> (raw)
In-Reply-To: <1403120530-27395-1-git-send-email-graham.williams@linaro.org>
On Wed, Jun 18, 2014 at 12:42:10PM -0700, Graham Williams wrote:
> The vbus regulator was not getting its name set. This results
> in the sysfs entry being empty. The lack of a bcm590xx_regs[]
> table entry also upsets Coverity runs. Add the table entry
> so the name gets set properly.
>
> Signed-off-by: Graham Williams <graham.williams@linaro.org>
> ---
> drivers/regulator/bcm590xx-regulator.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/regulator/bcm590xx-regulator.c b/drivers/regulator/bcm590xx-regulator.c
> index 57544e2..58ece59 100644
> --- a/drivers/regulator/bcm590xx-regulator.c
> +++ b/drivers/regulator/bcm590xx-regulator.c
> @@ -119,6 +119,10 @@ static const unsigned int ldo_c_table[] = {
> 2900000, 3000000, 3300000,
> };
>
> +static const unsigned int ldo_vbus[] = {
> + 5000000,
> +};
> +
> /* DCDC group CSR: supported voltages in microvolts */
> static const struct regulator_linear_range dcdc_csr_ranges[] = {
> REGULATOR_LINEAR_RANGE(860000, 2, 50, 10000),
> @@ -192,6 +196,7 @@ static struct bcm590xx_info bcm590xx_regs[] = {
> BCM590XX_REG_TABLE(gpldo4, ldo_a_table),
> BCM590XX_REG_TABLE(gpldo5, ldo_a_table),
> BCM590XX_REG_TABLE(gpldo6, ldo_a_table),
> + BCM590XX_REG_TABLE(vbus, ldo_vbus),
> };
Also fixes the functional problem for me on the Capri board, thanks.
Coverity should also be much happier now.
Acked-by: Matt Porter <mporter@linaro.org>
Mark: can you pick this up for 3.16 fixes?
-Matt
next prev parent reply other threads:[~2014-06-18 20:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 19:42 [PATCH] regulator: bcm590xx: fix vbus name Graham Williams
2014-06-18 20:32 ` Matt Porter [this message]
2014-06-22 11:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140618203234.GQ4173@beef \
--to=mporter@linaro.org \
--cc=broonie@kernel.org \
--cc=davej@redhat.com \
--cc=graham.williams@linaro.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox