[PATCH] regulator: bcm590xx: fix vbus name

[PATCH] regulator: bcm590xx: fix vbus name

[Graham Williams]

The vbus regulator was not getting its name set. This results
in the sysfs entry being empty. The lack of a bcm590xx_regs[]
table entry also upsets Coverity runs. Add the table entry
so the name gets set properly.

Signed-off-by: Graham Williams <graham.williams@linaro.org>
---
 drivers/regulator/bcm590xx-regulator.c |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/regulator/bcm590xx-regulator.c b/drivers/regulator/bcm590xx-regulator.c
index 57544e2..58ece59 100644
--- a/drivers/regulator/bcm590xx-regulator.c
+++ b/drivers/regulator/bcm590xx-regulator.c
@@ -119,6 +119,10 @@ static const unsigned int ldo_c_table[] = {
 	2900000, 3000000, 3300000,
 };
 
+static const unsigned int ldo_vbus[] = {
+	5000000,
+};
+
 /* DCDC group CSR: supported voltages in microvolts */
 static const struct regulator_linear_range dcdc_csr_ranges[] = {
 	REGULATOR_LINEAR_RANGE(860000, 2, 50, 10000),
@@ -192,6 +196,7 @@ static struct bcm590xx_info bcm590xx_regs[] = {
 	BCM590XX_REG_TABLE(gpldo4, ldo_a_table),
 	BCM590XX_REG_TABLE(gpldo5, ldo_a_table),
 	BCM590XX_REG_TABLE(gpldo6, ldo_a_table),
+	BCM590XX_REG_TABLE(vbus, ldo_vbus),
 };
 
 struct bcm590xx_reg {
-- 
1.7.9.5

Re: [PATCH] regulator: bcm590xx: fix vbus name

[Matt Porter]

On Wed, Jun 18, 2014 at 12:42:10PM -0700, Graham Williams wrote:
> The vbus regulator was not getting its name set. This results
> in the sysfs entry being empty. The lack of a bcm590xx_regs[]
> table entry also upsets Coverity runs. Add the table entry
> so the name gets set properly.
> 
> Signed-off-by: Graham Williams <graham.williams@linaro.org>
> ---
>  drivers/regulator/bcm590xx-regulator.c |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/regulator/bcm590xx-regulator.c b/drivers/regulator/bcm590xx-regulator.c
> index 57544e2..58ece59 100644
> --- a/drivers/regulator/bcm590xx-regulator.c
> +++ b/drivers/regulator/bcm590xx-regulator.c
> @@ -119,6 +119,10 @@ static const unsigned int ldo_c_table[] = {
>  	2900000, 3000000, 3300000,
>  };
>  
> +static const unsigned int ldo_vbus[] = {
> +	5000000,
> +};
> +
>  /* DCDC group CSR: supported voltages in microvolts */
>  static const struct regulator_linear_range dcdc_csr_ranges[] = {
>  	REGULATOR_LINEAR_RANGE(860000, 2, 50, 10000),
> @@ -192,6 +196,7 @@ static struct bcm590xx_info bcm590xx_regs[] = {
>  	BCM590XX_REG_TABLE(gpldo4, ldo_a_table),
>  	BCM590XX_REG_TABLE(gpldo5, ldo_a_table),
>  	BCM590XX_REG_TABLE(gpldo6, ldo_a_table),
> +	BCM590XX_REG_TABLE(vbus, ldo_vbus),
>  };

Also fixes the functional problem for me on the Capri board, thanks.
Coverity should also be much happier now.

Acked-by: Matt Porter <mporter@linaro.org>

Mark: can you pick this up for 3.16 fixes?

-Matt

Re: [PATCH] regulator: bcm590xx: fix vbus name

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

On Wed, Jun 18, 2014 at 12:42:10PM -0700, Graham Williams wrote:
> The vbus regulator was not getting its name set. This results
> in the sysfs entry being empty. The lack of a bcm590xx_regs[]
> table entry also upsets Coverity runs. Add the table entry
> so the name gets set properly.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]