* [PATCH] Fixes no Null check of dev_skb_alloc in fw_download_code
@ 2014-06-18 21:26 Nicholas Krause
2014-06-18 22:13 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Nicholas Krause @ 2014-06-18 21:26 UTC (permalink / raw)
To: gregkh; +Cc: valentina.manea.m, ben, lisa, devel, linux-kernel
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
index 1a95d1f..1a90546 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
@@ -61,6 +61,10 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,
}
skb = dev_alloc_skb(frag_length + 4);
+ if (!skb) {
+ rt_status = false;
+ return rt_status;
+ }
memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev));
tcb_desc = (struct cb_desc *)(skb->cb + MAX_DEV_ADDR_SIZE);
tcb_desc->queue_index = TXCMD_QUEUE;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Fixes no Null check of dev_skb_alloc in fw_download_code
2014-06-18 21:26 [PATCH] Fixes no Null check of dev_skb_alloc in fw_download_code Nicholas Krause
@ 2014-06-18 22:13 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2014-06-18 22:13 UTC (permalink / raw)
To: Nicholas Krause; +Cc: devel, lisa, ben, valentina.manea.m, linux-kernel
On Wed, Jun 18, 2014 at 05:26:18PM -0400, Nicholas Krause wrote:
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 4 ++++
> 1 file changed, 4 insertions(+)
Some more meta-comments. Your subject: should give people a clue as to
where in the kernel you are changing. This patch would be:
Subject: staging: rtl8192e: check return value of dev_skb_alloc
And then in the body of the patch changelog area, explain why you are
doing this.
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> index 1a95d1f..1a90546 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> @@ -61,6 +61,10 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,
> }
>
> skb = dev_alloc_skb(frag_length + 4);
> + if (!skb) {
> + rt_status = false;
> + return rt_status;
> + }
Does that really look like the correct thing to be doing here? Surely
you can delete 2 lines of this patch, right?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] Fixes no Null check of dev_skb_alloc in fw_download_code
@ 2014-06-18 22:18 Nicholas Krause
0 siblings, 0 replies; 3+ messages in thread
From: Nicholas Krause @ 2014-06-18 22:18 UTC (permalink / raw)
To: gregkh; +Cc: valentina.manea.m, ben, lisa, devel, linux-kernel
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
index 1a95d1f..1a90546 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
@@ -61,6 +61,10 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,
}
skb = dev_alloc_skb(frag_length + 4);
+ if (!skb) {
+ rt_status = false;
+ return rt_status;
+ }
memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev));
tcb_desc = (struct cb_desc *)(skb->cb + MAX_DEV_ADDR_SIZE);
tcb_desc->queue_index = TXCMD_QUEUE;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-18 22:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-18 21:26 [PATCH] Fixes no Null check of dev_skb_alloc in fw_download_code Nicholas Krause
2014-06-18 22:13 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2014-06-18 22:18 Nicholas Krause
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox