* [PATCHv2]staging:rtl8192e:check return value of dev_skb_alloc
@ 2014-06-18 22:23 Nicholas Krause
2014-06-18 22:49 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Nicholas Krause @ 2014-06-18 22:23 UTC (permalink / raw)
To: gregkh; +Cc: valentina.manea.m, ben, lisa, devel, linux-kernel
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
index 11e915e..fde17ff 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
@@ -62,12 +62,15 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,
skb = dev_alloc_skb(frag_length + 4);
+ if (!skb)
+ return !rt_status;
memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev));
tcb_desc = (struct cb_desc *)(skb->cb + MAX_DEV_ADDR_SIZE);
tcb_desc->queue_index = TXCMD_QUEUE;
tcb_desc->bCmdOrInit = DESC_PACKET_TYPE_INIT;
tcb_desc->bLastIniPkt = bLastIniPkt;
-
seg_ptr = skb->data;
for (i = 0; i < frag_length; i += 4) {
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCHv2]staging:rtl8192e:check return value of dev_skb_alloc
2014-06-18 22:23 [PATCHv2]staging:rtl8192e:check return value of dev_skb_alloc Nicholas Krause
@ 2014-06-18 22:49 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2014-06-18 22:49 UTC (permalink / raw)
To: Nicholas Krause; +Cc: devel, lisa, ben, valentina.manea.m, linux-kernel
On Wed, Jun 18, 2014 at 06:23:00PM -0400, Nicholas Krause wrote:
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> index 11e915e..fde17ff 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> @@ -62,12 +62,15 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,
>
> skb = dev_alloc_skb(frag_length + 4);
> + if (!skb)
> + return !rt_status;
> memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev));
> tcb_desc = (struct cb_desc *)(skb->cb + MAX_DEV_ADDR_SIZE);
> tcb_desc->queue_index = TXCMD_QUEUE;
> tcb_desc->bCmdOrInit = DESC_PACKET_TYPE_INIT;
> tcb_desc->bLastIniPkt = bLastIniPkt;
> -
>
> seg_ptr = skb->data;
> for (i = 0; i < frag_length; i += 4) {
Again, always use checkpatch.pl before sending out patches...
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-18 22:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-18 22:23 [PATCHv2]staging:rtl8192e:check return value of dev_skb_alloc Nicholas Krause
2014-06-18 22:49 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox