* [PATCHv4]staging:rtl8192e: check return value of dev_skb_alloc
@ 2014-06-18 23:10 Nicholas Krause
2014-06-18 23:18 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Nicholas Krause @ 2014-06-18 23:10 UTC (permalink / raw)
To: gregkh; +Cc: ben, lisa, valentina.manea.m, devel, linux-kernel
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
index 1a95d1f..1a90546 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
@@ -61,6 +61,10 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,
}
skb = dev_alloc_skb(frag_length + 4);
+ if (!skb)
+ !return rt_status;
memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev));
tcb_desc = (struct cb_desc *)(skb->cb + MAX_DEV_ADDR_SIZE);
tcb_desc->queue_index = TXCMD_QUEUE;
--
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCHv4]staging:rtl8192e: check return value of dev_skb_alloc
2014-06-18 23:10 [PATCHv4]staging:rtl8192e: check return value of dev_skb_alloc Nicholas Krause
@ 2014-06-18 23:18 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2014-06-18 23:18 UTC (permalink / raw)
To: Nicholas Krause; +Cc: ben, lisa, valentina.manea.m, devel, linux-kernel
On Wed, Jun 18, 2014 at 07:10:30PM -0400, Nicholas Krause wrote:
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> index 1a95d1f..1a90546 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> @@ -61,6 +61,10 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,
> }
>
> skb = dev_alloc_skb(frag_length + 4);
> + if (!skb)
> + !return rt_status;
> memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev));
> tcb_desc = (struct cb_desc *)(skb->cb + MAX_DEV_ADDR_SIZE);
> tcb_desc->queue_index = TXCMD_QUEUE;
> --
This is a joke now, right?
I'm going to give you a bit of time to step back, relax, and think about
what you are doing. Feel free to come back next week with a fixed and
correct patch when you go and read my previous review comments.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-18 23:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-18 23:10 [PATCHv4]staging:rtl8192e: check return value of dev_skb_alloc Nicholas Krause
2014-06-18 23:18 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox