From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756155AbaFRXOt (ORCPT ); Wed, 18 Jun 2014 19:14:49 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:43035 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756055AbaFRXOs (ORCPT ); Wed, 18 Jun 2014 19:14:48 -0400 Date: Wed, 18 Jun 2014 16:18:46 -0700 From: Greg KH To: Nicholas Krause Cc: ben@decadent.org.uk, lisa@xenapiadmin.com, valentina.manea.m@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv4]staging:rtl8192e: check return value of dev_skb_alloc Message-ID: <20140618231846.GC7234@kroah.com> References: <1403133030-6682-1-git-send-email-xerofoify@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1403133030-6682-1-git-send-email-xerofoify@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 18, 2014 at 07:10:30PM -0400, Nicholas Krause wrote: > diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c > index 1a95d1f..1a90546 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c > +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c > @@ -61,6 +61,10 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address, > } > > skb = dev_alloc_skb(frag_length + 4); > + if (!skb) > + !return rt_status; > memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev)); > tcb_desc = (struct cb_desc *)(skb->cb + MAX_DEV_ADDR_SIZE); > tcb_desc->queue_index = TXCMD_QUEUE; > -- This is a joke now, right? I'm going to give you a bit of time to step back, relax, and think about what you are doing. Feel free to come back next week with a fixed and correct patch when you go and read my previous review comments. greg k-h