From: Vinod Koul <vinod.koul@intel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Takashi Iwai <tiwai@suse.de>,
"Wang, Xiaoming" <xiaoming.wang@intel.com>,
jeeja.kp@intel.com, dhowells@redhat.com, tglx@linutronix.de,
mtk.manpages@gmail.com, paulmck@linux.vnet.ibm.com,
davej@redhat.com, linux-kernel@vger.kernel.org,
dongxing.zhang@intel.com
Subject: Re: [PATCH] ALSA: compress: Fix the mismatch size of struc between share lib(32bit) and kernel(64bit)
Date: Thu, 19 Jun 2014 10:43:00 +0530 [thread overview]
Message-ID: <20140619051300.GF22053@intel.com> (raw)
In-Reply-To: <201406171348.59329.arnd@arndb.de>
On Tue, Jun 17, 2014 at 01:48:59PM +0200, Arnd Bergmann wrote:
> On Tuesday 17 June 2014, Vinod Koul wrote:
> > > Anyway, if you use the __packed attribute, best apply it only to
> > > the individual __u64 member(s), not the entire struct, otherwise
> > > you might change user space programs in a subtle way when the alignment
> > > changes from 4 to 1 byte.
> >
> > then wouldn't it make sense to call out the aligned as well to ensure that it is
> > aligning to what we want. Then we should add aligned (4) everywhere as mostly we
> > need 4 byte aligned here
>
> If you want to be explicit, then just mark the entire structure as
> attribute((packed,aligned(4))), not each individual member.
Oh yes, thats the idea. I will send out and also while reviewing found that
packed was missing for few of other structs, so lets fix it now before 64bits
systems proliferate and cause havoc :)
--
~Vinod
prev parent reply other threads:[~2014-06-19 5:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 20:46 [PATCH] ALSA: compress: Fix the mismatch size of struc between share lib(32bit) and kernel(64bit) Wang, Xiaoming
2014-06-09 7:24 ` Takashi Iwai
2014-06-09 15:35 ` Vinod Koul
2014-06-12 6:39 ` Wang, Xiaoming
2014-06-13 14:19 ` Arnd Bergmann
2014-06-17 3:06 ` Vinod Koul
2014-06-17 11:48 ` Arnd Bergmann
2014-06-19 5:13 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140619051300.GF22053@intel.com \
--to=vinod.koul@intel.com \
--cc=arnd@arndb.de \
--cc=davej@redhat.com \
--cc=dhowells@redhat.com \
--cc=dongxing.zhang@intel.com \
--cc=jeeja.kp@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.de \
--cc=xiaoming.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox