From: Dan Carpenter <dan.carpenter@oracle.com>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
ben@decadent.org.uk, lisa@xenapiadmin.com,
valentina.manea.m@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: check return value of dev_skb_alloc
Date: Thu, 19 Jun 2014 08:29:10 +0300 [thread overview]
Message-ID: <20140619052910.GP5500@mwanda> (raw)
In-Reply-To: <1403144681-6902-1-git-send-email-xerofoify@gmail.com>
On Wed, Jun 18, 2014 at 10:24:41PM -0400, Nicholas Krause wrote:
> Checks if dev_skb_alloc returns Null in function, fw_download_code.
> If the return value of dev_skb_alloc is NULL return false and exit
> this function.
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> index 1a95d1f..38ae236 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
> @@ -62,6 +62,8 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,
>
> skb = dev_alloc_skb(frag_length + 4);
> memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev));
> + if (!skb)
> + return !rt_status;
What's this !rt_status? Just return false.
regards,
dan carpenter
next prev parent reply other threads:[~2014-06-19 5:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 2:24 [PATCH] staging: rtl8192e: check return value of dev_skb_alloc Nicholas Krause
2014-06-19 2:45 ` Greg KH
2014-06-19 4:14 ` Joe Perches
2014-06-19 5:29 ` Dan Carpenter [this message]
2014-06-19 18:41 ` Nick Krause
-- strict thread matches above, loose matches on Subject: below --
2014-06-19 19:29 Nicholas Krause
2014-06-19 21:25 ` Joe Perches
2014-06-20 16:31 ` Nick Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140619052910.GP5500@mwanda \
--to=dan.carpenter@oracle.com \
--cc=ben@decadent.org.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lisa@xenapiadmin.com \
--cc=valentina.manea.m@gmail.com \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox