Re: [PATCH 6/8] wlan-ng/prism2sta:checkpatch: Fix long lines

[josh@joshtriplett.org]

On Thu, Jun 19, 2014 at 09:20:18PM +0200, Johannes Stadlinger wrote:
> This patch fixes all warning of checkpatch about lines over 80
> characters.
> 
> Signed-off-by: Johannes Stadlinger <Johannes.Stadlinger@fau.de>
> Signed-off-by: Maximilian Eschenbacher <maximilian@eschenbacher.email>
> CC: linux-kernel@i4.cs.fau.de
> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> CC: Tugce Sirin <ztugcesirin@gmail.com>
> CC: Josh Triplett <josh@joshtriplett.org>
> CC: Neil Armstrong <superna9999@gmail.com>
> CC: Paul Gortmaker <paul.gortmaker@windriver.com>
> CC: Vitaly Osipov <vitaly.osipov@gmail.com>
> CC: devel@driverdev.osuosl.org
> CC: linux-kernel@vger.kernel.org

Most of these look fine, but...

> @@ -1271,7 +1275,8 @@ void prism2sta_processing_defer(struct work_struct *data)
>  				     HFA384x_RID_CURRENTSSID, result);
>  				return;
>  			}
> -			prism2mgmt_bytestr2pstr((struct hfa384x_bytestr *) &ssid,
> +			prism2mgmt_bytestr2pstr((struct hfa384x_bytestr *)
> +									&ssid,
>  						(p80211pstrd_t *) &
>  						wlandev->ssid);

...that (and the one in the subsequent context lines) looks horrible.
I'd suggest breaking after the opening parenthesis of the function call
and just indenting the arguments by one tab:
	foo_with_long_name(
		long_arg,
		another_long_arg);

Better yet, ignore checkpatch and format that call more readably as
though the 80 column rule didn't exist.