public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Chaitanya Hazarey <c@24.io>
Cc: dan.carpenter@oracle.com, burzalodowa@gmail.com,
	andrea.merello@gmail.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] Staging: rtl8192u: r8192U_wx.c Removed commented dead code
Date: Thu, 19 Jun 2014 15:12:53 -0700	[thread overview]
Message-ID: <20140619221253.GA5993@kroah.com> (raw)
In-Reply-To: <1401396321-29363-5-git-send-email-c@24.io>

On Thu, May 29, 2014 at 01:45:21PM -0700, Chaitanya Hazarey wrote:
> Removed dead code from the file.
> 
> Signed-off-by: Chaitanya Hazarey <c@24.io>
> ---
>  drivers/staging/rtl8192u/r8192U_wx.c | 18 +-----------------
>  1 file changed, 1 insertion(+), 17 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c
> index 09b1e81..ceb06d8 100644
> --- a/drivers/staging/rtl8192u/r8192U_wx.c
> +++ b/drivers/staging/rtl8192u/r8192U_wx.c
> @@ -516,12 +516,9 @@ static int r8192_wx_set_enc(struct net_device *dev,
>  	struct r8192_priv *priv = ieee80211_priv(dev);
>  	struct ieee80211_device *ieee = priv->ieee80211;
>  	int ret;
> -
> -	/* u32 TargetContent; */
>  	u32 hwkey[4] = {0, 0, 0, 0};
>  	u8 mask = 0xff;
>  	u32 key_idx = 0;
> -	/* u8 broadcast_addr[6] ={	0xff,0xff,0xff,0xff,0xff,0xff}; */
>  	u8 zero_addr[4][6] = {	{0x00, 0x00, 0x00, 0x00, 0x00, 0x00},
>  				{0x00, 0x00, 0x00, 0x00, 0x00, 0x01},
>  				{0x00, 0x00, 0x00, 0x00, 0x00, 0x02},
> @@ -667,14 +664,6 @@ static int r8192_wx_set_retry(struct net_device *dev,
>  	 */
>  
>  	rtl8192_commit(dev);
> -	/*
> -	if(priv->up){
> -		rtl8180_rtx_disable(dev);
> -		rtl8180_rx_enable(dev);
> -		rtl8180_tx_enable(dev);
> -
> -	}
> -	*/
>  exit:
>  	up(&priv->wx_sem);
>  
> @@ -953,14 +942,9 @@ static const struct iw_priv_args r8192_private_args[] = {
>  
>  
>  static iw_handler r8192_private_handler[] = {
> -	/* r8192_wx_set_monitor, */ /* SIOCIWFIRSTPRIV */
> -	r8192_wx_set_crcmon,   /*SIOCIWSECONDPRIV*/
> -	/* r8192_wx_set_forceassociate, */
> -	/* r8192_wx_set_beaconinterval, */
> -	/* r8192_wx_set_monitor_type, */
> +	r8192_wx_set_crcmon, 
>  	r8192_wx_set_scan_type,
>  	r8192_wx_set_rawtx,
> -	/* r8192_wx_null, */
>  	r8192_wx_force_reset,
>  };

This patch adds a checkpatch error, so I can't take it :(


  reply	other threads:[~2014-06-19 22:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-29 20:45 [PATCH 1/5] Staging: rtl8192u: r8192U_wx.c Fixed one misplaced brace Chaitanya Hazarey
2014-05-29 20:45 ` [PATCH 2/5] Staging: rtl8192u: r8192U_wx.c removed commented dead code Chaitanya Hazarey
2014-05-29 20:45 ` [PATCH 3/5] Staging: rtl8192u: r8192U_wx.c Removed all C99 comments Chaitanya Hazarey
2014-05-29 20:45 ` [PATCH 4/5] Staging: rtl8192u: r8192U_wx.c Added a single space for code-style issue Chaitanya Hazarey
2014-05-29 20:45 ` [PATCH 5/5] Staging: rtl8192u: r8192U_wx.c Removed commented dead code Chaitanya Hazarey
2014-06-19 22:12   ` Greg KH [this message]
2014-06-19 22:12 ` [PATCH 1/5] Staging: rtl8192u: r8192U_wx.c Fixed one misplaced brace Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140619221253.GA5993@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andrea.merello@gmail.com \
    --cc=burzalodowa@gmail.com \
    --cc=c@24.io \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox