* [PATCH] staging: rtl8172u: Make ieee80211_crypto_init static @ 2014-06-12 17:40 L. Alberto Giménez 2014-06-20 0:14 ` Greg Kroah-Hartman 0 siblings, 1 reply; 4+ messages in thread From: L. Alberto Giménez @ 2014-06-12 17:40 UTC (permalink / raw) To: devel; +Cc: Greg Kroah-Hartman, open list Fix sparse warning. Signed-off-by: L. Alberto Giménez <agimenez@sysvalve.es> --- drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c index 5533221..3be690d 100644 --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c @@ -200,7 +200,7 @@ static struct ieee80211_crypto_ops ieee80211_crypt_null = { .owner = THIS_MODULE, }; -int __init ieee80211_crypto_init(void) +static int __init ieee80211_crypto_init(void) { int ret = -ENOMEM; -- 2.0.0.rc0 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8172u: Make ieee80211_crypto_init static 2014-06-12 17:40 [PATCH] staging: rtl8172u: Make ieee80211_crypto_init static L. Alberto Giménez @ 2014-06-20 0:14 ` Greg Kroah-Hartman 2014-06-21 10:04 ` L. Alberto Giménez 0 siblings, 1 reply; 4+ messages in thread From: Greg Kroah-Hartman @ 2014-06-20 0:14 UTC (permalink / raw) To: L. Alberto Giménez; +Cc: devel, open list On Thu, Jun 12, 2014 at 07:40:49PM +0200, L. Alberto Giménez wrote: > Fix sparse warning. > > Signed-off-by: L. Alberto Giménez <agimenez@sysvalve.es> > --- > drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c > index 5533221..3be690d 100644 > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c > @@ -200,7 +200,7 @@ static struct ieee80211_crypto_ops ieee80211_crypt_null = { > .owner = THIS_MODULE, > }; > > -int __init ieee80211_crypto_init(void) > +static int __init ieee80211_crypto_init(void) > { > int ret = -ENOMEM; You obviously did not compile this change :( greg k-h ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8172u: Make ieee80211_crypto_init static 2014-06-20 0:14 ` Greg Kroah-Hartman @ 2014-06-21 10:04 ` L. Alberto Giménez 2014-06-21 20:16 ` Greg Kroah-Hartman 0 siblings, 1 reply; 4+ messages in thread From: L. Alberto Giménez @ 2014-06-21 10:04 UTC (permalink / raw) To: Greg Kroah-Hartman; +Cc: devel, open list On Thu, Jun 19, 2014 at 05:14:26PM -0700, Greg Kroah-Hartman wrote: > On Thu, Jun 12, 2014 at 07:40:49PM +0200, L. Alberto Giménez wrote: > > Fix sparse warning. > > > > Signed-off-by: L. Alberto Giménez <agimenez@sysvalve.es> > > --- > > drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c > > index 5533221..3be690d 100644 > > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c > > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c > > @@ -200,7 +200,7 @@ static struct ieee80211_crypto_ops ieee80211_crypt_null = { > > .owner = THIS_MODULE, > > }; > > > > -int __init ieee80211_crypto_init(void) > > +static int __init ieee80211_crypto_init(void) > > { > > int ret = -ENOMEM; > > You obviously did not compile this change :( > > greg k-h Hi Greg, I'm very sorry for that, I swear I compiled it, but clearly I'm missing something here. My patch compiles with a warning, but tag v3.15 (tag where my branch is based) does not issue this warning: drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c:203:19: warning: ‘ieee80211_crypto_init’ defined but not used [-Wunused-function] static int __init ieee80211_crypto_init(void) ^ I thought that __init functions could be static, is there any problem with that? Care to shed some light here? Thank you very much -- L. Alberto Giménez GnuPG key ID 0xDD4E27AB ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8172u: Make ieee80211_crypto_init static 2014-06-21 10:04 ` L. Alberto Giménez @ 2014-06-21 20:16 ` Greg Kroah-Hartman 0 siblings, 0 replies; 4+ messages in thread From: Greg Kroah-Hartman @ 2014-06-21 20:16 UTC (permalink / raw) To: L. Alberto Giménez; +Cc: devel, open list On Sat, Jun 21, 2014 at 12:04:44PM +0200, L. Alberto Giménez wrote: > On Thu, Jun 19, 2014 at 05:14:26PM -0700, Greg Kroah-Hartman wrote: > > On Thu, Jun 12, 2014 at 07:40:49PM +0200, L. Alberto Giménez wrote: > > > Fix sparse warning. > > > > > > Signed-off-by: L. Alberto Giménez <agimenez@sysvalve.es> > > > --- > > > drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c > > > index 5533221..3be690d 100644 > > > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c > > > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c > > > @@ -200,7 +200,7 @@ static struct ieee80211_crypto_ops ieee80211_crypt_null = { > > > .owner = THIS_MODULE, > > > }; > > > > > > -int __init ieee80211_crypto_init(void) > > > +static int __init ieee80211_crypto_init(void) > > > { > > > int ret = -ENOMEM; > > > > You obviously did not compile this change :( > > > > greg k-h > > Hi Greg, > > I'm very sorry for that, I swear I compiled it, but clearly I'm missing something > here. > > My patch compiles with a warning, but tag v3.15 (tag where my branch is based) does > not issue this warning: > > drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c:203:19: warning: > ‘ieee80211_crypto_init’ defined but not used [-Wunused-function] > static int __init ieee80211_crypto_init(void) > ^ > > I thought that __init functions could be static, is there any problem with that? Care > to shed some light here? That function is called by a different file, it can not be static, I don't know how you were able to successfully build the driver with your change... ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-06-21 20:16 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-06-12 17:40 [PATCH] staging: rtl8172u: Make ieee80211_crypto_init static L. Alberto Giménez 2014-06-20 0:14 ` Greg Kroah-Hartman 2014-06-21 10:04 ` L. Alberto Giménez 2014-06-21 20:16 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox