[PATCH v2 1/2] alarmtimer: Export symbols of alarmtimer_get_rtcdev

[PATCH v2 1/2] alarmtimer: Export symbols of alarmtimer_get_rtcdev

[pramod.gurav.etc]

From: Pramod Gurav <pramod.gurav.etc@gmail.com>

Export symbol of alarmtimer_get_rtcdev so that it is used by
any driver when built as module like,
drivers/staging/android/alarm-dev.c.

CC: John Stultz <john.stultz@linaro.org>
CC: Marcus Gelderie <redmnic@gmail.com>
CC: Greg Kroah-Hartman <greg@kroah.com>
Signed-off-by: Pramod Gurav <pramod.gurav.etc@gmail.com>
---

This Export was missing in Marcus's below patch:

https://lkml.org/lkml/2013/6/1/144

Changes since v1:
 -Removed trivial list from CC

 kernel/time/alarmtimer.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/time/alarmtimer.c b/kernel/time/alarmtimer.c
index 88c9c65..a53ba0b 100644
--- a/kernel/time/alarmtimer.c
+++ b/kernel/time/alarmtimer.c
@@ -71,7 +71,7 @@ struct rtc_device *alarmtimer_get_rtcdev(void)
 
 	return ret;
 }
-
+EXPORT_SYMBOL_GPL(alarmtimer_get_rtcdev);
 
 static int alarmtimer_rtc_add_device(struct device *dev,
 				struct class_interface *class_intf)
-- 
1.7.9.5

[PATCH v2 2/2] staging: alarm-dev: Support to Compile as Module

[pramod.gurav.etc]

From: Pramod Gurav <pramod.gurav.etc@gmail.com>

Currently this alarm-dev can be compiles only as built in
driver. This adds support to compile it as module as well which is in
planned activity (See drivers/staging/android/TODO)


CC: Greg Kroah-Hartman <greg@kroah.com>
CC: Brian Swetland <swetland@google.com>
Signed-off-by: Pramod Gurav <pramod.gurav.etc@gmail.com>
---
 drivers/staging/android/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/android/Kconfig b/drivers/staging/android/Kconfig
index 99e484f..c359317 100644
--- a/drivers/staging/android/Kconfig
+++ b/drivers/staging/android/Kconfig
@@ -76,7 +76,7 @@ config ANDROID_LOW_MEMORY_KILLER
 	  Registers processes to be killed when memory is low
 
 config ANDROID_INTF_ALARM_DEV
-	bool "Android alarm driver"
+	tristate "Android alarm driver"
 	depends on RTC_CLASS
 	default n
 	---help---
-- 
1.7.9.5

Re: [PATCH v2 2/2] staging: alarm-dev: Support to Compile as Module

[Greg Kroah-Hartman]

On Fri, Jun 13, 2014 at 11:49:43AM +0530, pramod.gurav.etc@gmail.com wrote:
> From: Pramod Gurav <pramod.gurav.etc@gmail.com>
> 
> Currently this alarm-dev can be compiles only as built in
> driver. This adds support to compile it as module as well which is in
> planned activity (See drivers/staging/android/TODO)
> 
> 
> CC: Greg Kroah-Hartman <greg@kroah.com>
> CC: Brian Swetland <swetland@google.com>
> Signed-off-by: Pramod Gurav <pramod.gurav.etc@gmail.com>
> ---
>  drivers/staging/android/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/android/Kconfig b/drivers/staging/android/Kconfig
> index 99e484f..c359317 100644
> --- a/drivers/staging/android/Kconfig
> +++ b/drivers/staging/android/Kconfig
> @@ -76,7 +76,7 @@ config ANDROID_LOW_MEMORY_KILLER
>  	  Registers processes to be killed when memory is low
>  
>  config ANDROID_INTF_ALARM_DEV
> -	bool "Android alarm driver"
> +	tristate "Android alarm driver"
>  	depends on RTC_CLASS
>  	default n
>  	---help---

With this change you will get a warning about a missing
MODULE_LICENSE(), can you please send a follow-on patch to fix that?

thanks,

greg k-h