From: Dan Carpenter <dan.carpenter@oracle.com>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: devel@driverdev.osuosl.org,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Thomas Cort <linuxgeek@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH] staging: rtl8712: rtl871x_ioctl_linux.c: Cleaning up useless if statement
Date: Fri, 20 Jun 2014 13:59:03 +0300 [thread overview]
Message-ID: <20140620105903.GT5500@mwanda> (raw)
In-Reply-To: <CAFo99gY+UQQdTiRzF8Ca9tYzcty90yHQ3paR9-67tYHcr_JZhQ@mail.gmail.com>
On Fri, Jun 20, 2014 at 12:46:33PM +0200, Rickard Strandqvist wrote:
> Hi
>
> It's a bit confusing with this, I have received a lot of complaints
> that I have not had a cover letter.
> When should I include it? In an obvious patching. But where there's a
> need to explain anything further should have a cover letter.
Cover letters are for if you have a series of patches and they follow a
theme. "Add support for XXX feature in a series of 8 patches". "What
is in my pull request for the new kernel." It's just a shorter summary.
This is just one patch not a series.
I have never sent a cover letter in my life. I don't know who is
complaining to you...
In this case the changelog would have been better and more complete if
all the cover letter information were in the permanent commit log.
regards,
dan carpenter
prev parent reply other threads:[~2014-06-20 10:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-15 17:20 [PATCH] staging: rtl8712: rtl871x_ioctl_linux.c: Cleaning up useless if statement Rickard Strandqvist
2014-06-15 17:20 ` Rickard Strandqvist
2014-06-16 9:05 ` Dan Carpenter
2014-06-20 10:46 ` Rickard Strandqvist
2014-06-20 10:59 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140620105903.GT5500@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxgeek@gmail.com \
--cc=paul.gortmaker@windriver.com \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox