From: Dan Carpenter <dan.carpenter@oracle.com>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: crystalhd: Do not mix integers and user pointers
Date: Fri, 20 Jun 2014 14:34:26 +0300 [thread overview]
Message-ID: <20140620113426.GU5500@mwanda> (raw)
In-Reply-To: <1403262977-26100-1-git-send-email-lkundrak@v3.sk>
On Fri, Jun 20, 2014 at 01:16:17PM +0200, Lubomir Rintel wrote:
> Fixes the following sparse warnings:
>
> crystalhd/crystalhd_lnx.c:227:61: warning: incorrect type in argument 3 (different base types)
> crystalhd/crystalhd_lnx.c:227:61: expected unsigned long [unsigned] ua
> crystalhd/crystalhd_lnx.c:227:61: got void [noderef] <asn:1>*ua
> crystalhd/crystalhd_lnx.c:229:65: warning: incorrect type in argument 4 (different base types)
> crystalhd/crystalhd_lnx.c:229:65: expected unsigned long [unsigned] ua
> crystalhd/crystalhd_lnx.c:229:65: got void [noderef] <asn:1>*ua
>
> Done for the Eudyptula challenge.
>
This patch is nice and fixes a bunch of warnings.
Normally, I would might you to redo it and remove the no longer needed
casts for ua_off as well...
crystalhd_user_data((void __user *)ua_off, io->add_cdata,
^^^^^^^^^^^^^^^
But we are going to delete this entire driver soon. We may as well
apply yours as is and then delete it or just delete the driver without
applying this cleanup.
regards,
dan carpenter
next prev parent reply other threads:[~2014-06-20 11:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 11:16 [PATCH] staging: crystalhd: Do not mix integers and user pointers Lubomir Rintel
2014-06-20 11:34 ` Dan Carpenter [this message]
2014-06-20 15:14 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140620113426.GU5500@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox