Re: [PATCH] staging: crystalhd: Do not mix integers and user pointers

Greg Kroah-Hartman
2014-06-20T15:10:31Z

On Fri, Jun 20, 2014 at 02:34:26PM +0300, Dan Carpenter wrote:
> On Fri, Jun 20, 2014 at 01:16:17PM +0200, Lubomir Rintel wrote:
> > Fixes the following sparse warnings:
> >
> > crystalhd/crystalhd_lnx.c:227:61: warning: incorrect type in argument 3 (different base types)
> > crystalhd/crystalhd_lnx.c:227:61: expected unsigned long [unsigned] ua
> > crystalhd/crystalhd_lnx.c:227:61: got void [noderef] <asn:1>*ua
> > crystalhd/crystalhd_lnx.c:229:65: warning: incorrect type in argument 4 (different base types)
> > crystalhd/crystalhd_lnx.c:229:65: expected unsigned long [unsigned] ua
> > crystalhd/crystalhd_lnx.c:229:65: got void [noderef] <asn:1>*ua
> >
> > Done for the Eudyptula challenge.
> >
>
> This patch is nice and fixes a bunch of warnings.
>
> Normally, I would might you to redo it and remove the no longer needed
> casts for ua_off as well...
>
> crystalhd_user_data((void __user *)ua_off, io->add_cdata,
> ^^^^^^^^^^^^^^^
> But we are going to delete this entire driver soon. We may as well
> apply yours as is and then delete it or just delete the driver without
> applying this cleanup.

Yeah, I'm just going to go delete this driver right now, so I will not
apply this patch, sorry :(

greg k-h