From: Dan Carpenter <dan.carpenter@oracle.com>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
lisa@xenapiadmin.com, ben@decadent.org.uk,
valentina.manea.m@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192 Check for Null return from dev_skb_alloc
Date: Fri, 20 Jun 2014 22:53:34 +0300 [thread overview]
Message-ID: <20140620195334.GX5500@mwanda> (raw)
In-Reply-To: <1403282995-6688-1-git-send-email-xerofoify@gmail.com>
On Fri, Jun 20, 2014 at 12:49:55PM -0400, Nicholas Krause wrote:
> Checks for Null return from dev_skb_alloc if it returns Null,
> fw_download returns false. Otherwise it returns true.Also
> removed rt_status due to returning true of false directly.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
What is this? This patch is really bad and also doesn't apply. Greg
already told you not to send any more patches until next week so it's
just going to be ignored...
Please slow down and don't send this again until it is correct.
regards,
dan carpenter
next prev parent reply other threads:[~2014-06-20 19:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 16:49 [PATCH] staging: rtl8192 Check for Null return from dev_skb_alloc Nicholas Krause
2014-06-20 19:53 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-06-19 21:18 Nicholas Krause
2014-06-20 2:12 ` Nick Krause
2014-06-20 3:46 ` Nick Krause
2014-06-19 20:18 Nicholas Krause
2014-06-19 20:20 ` Nick Krause
2014-06-19 20:51 ` Joe Perches
2014-06-19 20:53 ` Joe Perches
2014-06-19 21:12 ` Nick Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140620195334.GX5500@mwanda \
--to=dan.carpenter@oracle.com \
--cc=ben@decadent.org.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lisa@xenapiadmin.com \
--cc=valentina.manea.m@gmail.com \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox