From: Dan Carpenter <dan.carpenter@oracle.com>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
pebolle@tiscali.nl, himangi774@gmail.com, bergo.torino@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging:rtl8821ae: rewrite legacy wifi check in halbcoutsrc
Date: Fri, 20 Jun 2014 22:59:26 +0300 [thread overview]
Message-ID: <20140620195926.GY5500@mwanda> (raw)
In-Reply-To: <1403283410-7022-1-git-send-email-xerofoify@gmail.com>
On Fri, Jun 20, 2014 at 12:56:50PM -0400, Nicholas Krause wrote:
> Rewrites the wireless check for legacy checking in function
> halbtc_legacy to check for both Mode A and B.
You're just guessing that A and B were intended but it could have been
something B and G...
Don't do this. Just leave the static checker warning there so someone
can fix it properly instead of introducing a second new bug and hiding
the warning so it's impossible to find.
regards,
dan carpenter
next prev parent reply other threads:[~2014-06-20 19:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 16:56 [PATCH] staging:rtl8821ae: rewrite legacy wifi check in halbcoutsrc Nicholas Krause
2014-06-20 19:59 ` Dan Carpenter [this message]
2014-06-20 20:08 ` Joe Perches
2014-06-21 2:26 ` Nick Krause
2014-06-21 2:34 ` Joe Perches
2014-06-21 2:52 ` Nick Krause
2014-06-21 13:06 ` Larry Finger
[not found] ` <CAPDOMVgvnNkVc9TN4MHm7UaD+nfac8C6A0kMo=q9Q237nTWUKQ@mail.gmail.com>
2014-06-21 20:14 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140620195926.GY5500@mwanda \
--to=dan.carpenter@oracle.com \
--cc=bergo.torino@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=himangi774@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox