From: Pawel Lebioda <pawel.lebioda89@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH] staging: cxt1e1: fix sbeCrc function declaration
Date: Sat, 21 Jun 2014 19:29:35 +0200 [thread overview]
Message-ID: <20140621172931.GA13116@ThinkPad> (raw)
Hi,
This patch fixes the following sparse warning:
drivers/staging/cxt1e1/sbecrc.c:86:1: warning: symbol 'sbeCrc' was not declared. Should it be static?
Furthermore it fixes wring sbeCrc return type in function declaration.
Regards
Pawel Lebioda
Signed-off-by: Pawel Lebioda <pawel.lebioda89@gmail.com>
---
drivers/staging/cxt1e1/pmcc4.h | 2 +-
drivers/staging/cxt1e1/pmcc4_private.h | 1 +
drivers/staging/cxt1e1/sbecrc.c | 1 +
3 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/cxt1e1/pmcc4.h b/drivers/staging/cxt1e1/pmcc4.h
index b4b5e5a..0220bbf 100644
--- a/drivers/staging/cxt1e1/pmcc4.h
+++ b/drivers/staging/cxt1e1/pmcc4.h
@@ -94,7 +94,7 @@ void sbecom_set_loglevel (int debuglevel);
char *sbeid_get_bdname (ci_t *ci);
void sbeid_set_bdtype (ci_t *ci);
void sbeid_set_hdwbid (ci_t *ci);
-u_int32_t sbeCrc (u_int8_t *, u_int32_t, u_int32_t, u_int32_t *);
+void sbeCrc(u_int8_t *, u_int32_t, u_int32_t, u_int32_t *);
void VMETRO_TRIGGER (ci_t *, int); /* Note: int = 0(default)
* thru 15 */
diff --git a/drivers/staging/cxt1e1/pmcc4_private.h b/drivers/staging/cxt1e1/pmcc4_private.h
index 451f12f..134ddd6 100644
--- a/drivers/staging/cxt1e1/pmcc4_private.h
+++ b/drivers/staging/cxt1e1/pmcc4_private.h
@@ -33,6 +33,7 @@
#include "musycc.h"
#include "sbe_promformat.h"
#include "comet.h"
+#include "sbecom_inline_linux.h"
/* driver state */
diff --git a/drivers/staging/cxt1e1/sbecrc.c b/drivers/staging/cxt1e1/sbecrc.c
index a51780f..52d3f71 100644
--- a/drivers/staging/cxt1e1/sbecrc.c
+++ b/drivers/staging/cxt1e1/sbecrc.c
@@ -16,6 +16,7 @@
*/
#include <linux/types.h>
+#include "pmcc4.h"
#include "pmcc4_sysdep.h"
#include "sbecom_inline_linux.h"
#include "sbe_promformat.h"
reply other threads:[~2014-06-21 17:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140621172931.GA13116@ThinkPad \
--to=pawel.lebioda89@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox