From: Peter Zijlstra <peterz@infradead.org>
To: Kirill Tkhai <ktkhai@parallels.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
tkhai@yandex.ru, Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Mike Galbraith <umgwanakikbuti@gmail.com>,
Konstantin Khorenko <khorenko@parallels.com>
Subject: Re: [PATCH 1/3] sched/fair: Disable runtime_enabled on dying rq
Date: Mon, 23 Jun 2014 12:07:24 +0200 [thread overview]
Message-ID: <20140623100724.GU19860@laptop.programming.kicks-ass.net> (raw)
In-Reply-To: <1403011450.27674.44.camel@tkhai>
On Tue, Jun 17, 2014 at 05:24:10PM +0400, Kirill Tkhai wrote:
> @@ -3790,6 +3803,12 @@ static void __maybe_unused unthrottle_offline_cfs_rqs(struct rq *rq)
> cfs_rq->runtime_remaining = 1;
> if (cfs_rq_throttled(cfs_rq))
> unthrottle_cfs_rq(cfs_rq);
> +
> + /*
> + * Offline rq is schedulable till cpu is completely disabled
> + * in take_cpu_down(), so we prevent new cfs throttling here.
> + */
> + cfs_rq->runtime_enabled = 0;
Does it make sense to clear this before calling unthrottle_cfs_rq()?
Just to make sure they're in the right order..
> }
> }
next prev parent reply other threads:[~2014-06-23 10:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140617130442.29933.54945.stgit@tkhai>
2014-06-17 13:24 ` [PATCH 1/3] sched/fair: Disable runtime_enabled on dying rq Kirill Tkhai
2014-06-23 10:07 ` Peter Zijlstra [this message]
2014-06-23 10:58 ` Kirill Tkhai
2014-06-23 17:29 ` bsegall
2014-06-23 20:49 ` Kirill Tkhai
2014-06-23 21:05 ` bsegall
2014-06-23 21:15 ` Kirill Tkhai
2014-06-17 13:24 ` [PATCH 2/3] sched/rt: __disable_runtime: Enqueue just unthrottled rt_rq back on the stack Kirill Tkhai
2014-06-23 10:12 ` Peter Zijlstra
2014-06-17 13:24 ` [PATCH 3/3] sched: Rework check_for_tasks() Kirill Tkhai
2014-06-23 10:24 ` Peter Zijlstra
2014-06-23 10:52 ` Kirill Tkhai
2014-06-23 14:21 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140623100724.GU19860@laptop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=khorenko@parallels.com \
--cc=ktkhai@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=tkhai@yandex.ru \
--cc=umgwanakikbuti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox