public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Kirill Tkhai <ktkhai@parallels.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
	tkhai@yandex.ru, Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
	Mike Galbraith <umgwanakikbuti@gmail.com>,
	Konstantin Khorenko <khorenko@parallels.com>
Subject: Re: [PATCH 2/3] sched/rt: __disable_runtime: Enqueue just unthrottled rt_rq back on the stack
Date: Mon, 23 Jun 2014 12:12:13 +0200	[thread overview]
Message-ID: <20140623101213.GV19860@laptop.programming.kicks-ass.net> (raw)
In-Reply-To: <1403011456.27674.45.camel@tkhai>

On Tue, Jun 17, 2014 at 05:24:16PM +0400, Kirill Tkhai wrote:
> 
> Make rt_rq available for pick_next_task(). Otherwise, their tasks
> stay prisoned long time till dead cpu becomes alive again.
> 
> Signed-off-by: Kirill Tkhai <ktkhai@parallels.com>
> CC: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> CC: Mike Galbraith <umgwanakikbuti@gmail.com>
> CC: Peter Zijlstra <peterz@infradead.org>
> CC: Ingo Molnar <mingo@kernel.org>
> ---
>  kernel/sched/rt.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
> index a490831..671a8b5 100644
> --- a/kernel/sched/rt.c
> +++ b/kernel/sched/rt.c
> @@ -740,6 +740,9 @@ balanced:

Depending on what you use to generate patches, can you:

QUILT_DIFF_OPTS="-F ^[[:alpha:]\$_].*[^:]\$"

or .gitconfig:

[diff "default"]
        xfuncname = "^[[:alpha:]$_].*[^:]$"

That avoids mistaking labels (like the above balanced:) for function
names.

The patch itself makes sense though.

  reply	other threads:[~2014-06-23 10:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20140617130442.29933.54945.stgit@tkhai>
2014-06-17 13:24 ` [PATCH 1/3] sched/fair: Disable runtime_enabled on dying rq Kirill Tkhai
2014-06-23 10:07   ` Peter Zijlstra
2014-06-23 10:58     ` Kirill Tkhai
2014-06-23 17:29     ` bsegall
2014-06-23 20:49       ` Kirill Tkhai
2014-06-23 21:05         ` bsegall
2014-06-23 21:15           ` Kirill Tkhai
2014-06-17 13:24 ` [PATCH 2/3] sched/rt: __disable_runtime: Enqueue just unthrottled rt_rq back on the stack Kirill Tkhai
2014-06-23 10:12   ` Peter Zijlstra [this message]
2014-06-17 13:24 ` [PATCH 3/3] sched: Rework check_for_tasks() Kirill Tkhai
2014-06-23 10:24   ` Peter Zijlstra
2014-06-23 10:52     ` Kirill Tkhai
2014-06-23 14:21       ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140623101213.GV19860@laptop.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=khorenko@parallels.com \
    --cc=ktkhai@parallels.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=srikar@linux.vnet.ibm.com \
    --cc=tkhai@yandex.ru \
    --cc=umgwanakikbuti@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox