[Patch] tracing: tell mm_migrate_pages event about numa_misplaced

[Patch] tracing: tell mm_migrate_pages event about numa_misplaced

[Max Asbock]

The mm_migrate_pages trace event reports a reason for the migration, typically as a
symbolic string. The exception is the reason MR_NUMA_MISPLACED for which it just displays
the numeric value:
mm_migrate_pages: nr_succeeded=1 nr_failed=0 mode=MIGRATE_ASYNC reason=0x5

This patch makes the output consistent by introducing a string value for MR_NUMA_MISPLACED.
The event is then reported as:
mm_migrate_pages: nr_succeeded=1 nr_failed=0 mode=MIGRATE_ASYNC reason=numa_misplaced

Signed-off-by: Max Asbock <masbock@linux.vnet.ibm.com>

 migrate.h |    1 +
 1 file changed, 1 insertion(+)


--- linux-3.16-rc1/include/trace/events/migrate.h.orig	2014-06-20 10:00:26.768410407 -0700
+++ linux-3.16-rc1/include/trace/events/migrate.h	2014-06-20 10:01:55.432410334 -0700
@@ -17,6 +17,7 @@
 	{MR_MEMORY_HOTPLUG,	"memory_hotplug"},		\
 	{MR_SYSCALL,		"syscall_or_cpuset"},		\
 	{MR_MEMPOLICY_MBIND,	"mempolicy_mbind"},		\
+	{MR_NUMA_MISPLACED,	"numa_misplaced"},		\
 	{MR_CMA,		"cma"}
 
 TRACE_EVENT(mm_migrate_pages,

Re: [Patch] tracing: tell mm_migrate_pages event about numa_misplaced

[Mel Gorman]

On Fri, Jun 20, 2014 at 11:49:16AM -0700, Max Asbock wrote:
> 
> The mm_migrate_pages trace event reports a reason for the migration, typically as a
> symbolic string. The exception is the reason MR_NUMA_MISPLACED for which it just displays
> the numeric value:
> mm_migrate_pages: nr_succeeded=1 nr_failed=0 mode=MIGRATE_ASYNC reason=0x5
> 
> This patch makes the output consistent by introducing a string value for MR_NUMA_MISPLACED.
> The event is then reported as:
> mm_migrate_pages: nr_succeeded=1 nr_failed=0 mode=MIGRATE_ASYNC reason=numa_misplaced
> 
> Signed-off-by: Max Asbock <masbock@linux.vnet.ibm.com>

Acked-by: Mel Gorman <mgorman@suse.de>

-- 
Mel Gorman
SUSE Labs

Re: [Patch] tracing: tell mm_migrate_pages event about numa_misplaced

[Steven Rostedt]

On Mon, 23 Jun 2014 15:21:59 +0100
Mel Gorman <mgorman@suse.de> wrote:

> On Fri, Jun 20, 2014 at 11:49:16AM -0700, Max Asbock wrote:
> > 
> > The mm_migrate_pages trace event reports a reason for the migration, typically as a
> > symbolic string. The exception is the reason MR_NUMA_MISPLACED for which it just displays
> > the numeric value:
> > mm_migrate_pages: nr_succeeded=1 nr_failed=0 mode=MIGRATE_ASYNC reason=0x5
> > 
> > This patch makes the output consistent by introducing a string value for MR_NUMA_MISPLACED.
> > The event is then reported as:
> > mm_migrate_pages: nr_succeeded=1 nr_failed=0 mode=MIGRATE_ASYNC reason=numa_misplaced
> > 
> > Signed-off-by: Max Asbock <masbock@linux.vnet.ibm.com>
> 
> Acked-by: Mel Gorman <mgorman@suse.de>
> 

Would you like to take this? Or Andrew?

You can add my Acked-by: Steven Rostedt <rostedt@goodmis.org>


-- Steve

Re: [Patch] tracing: tell mm_migrate_pages event about numa_misplaced

[Mel Gorman]

On Mon, Jun 23, 2014 at 10:31:11AM -0400, Steven Rostedt wrote:
> On Mon, 23 Jun 2014 15:21:59 +0100
> Mel Gorman <mgorman@suse.de> wrote:
> 
> > On Fri, Jun 20, 2014 at 11:49:16AM -0700, Max Asbock wrote:
> > > 
> > > The mm_migrate_pages trace event reports a reason for the migration, typically as a
> > > symbolic string. The exception is the reason MR_NUMA_MISPLACED for which it just displays
> > > the numeric value:
> > > mm_migrate_pages: nr_succeeded=1 nr_failed=0 mode=MIGRATE_ASYNC reason=0x5
> > > 
> > > This patch makes the output consistent by introducing a string value for MR_NUMA_MISPLACED.
> > > The event is then reported as:
> > > mm_migrate_pages: nr_succeeded=1 nr_failed=0 mode=MIGRATE_ASYNC reason=numa_misplaced
> > > 
> > > Signed-off-by: Max Asbock <masbock@linux.vnet.ibm.com>
> > 
> > Acked-by: Mel Gorman <mgorman@suse.de>
> > 
> 
> Would you like to take this? Or Andrew?
> 

I expect Andrew will pick it up.

-- 
Mel Gorman
SUSE Labs