* [Patch] tracing: tell mm_migrate_pages event about numa_misplaced
@ 2014-06-20 18:49 Max Asbock
2014-06-23 14:21 ` Mel Gorman
0 siblings, 1 reply; 4+ messages in thread
From: Max Asbock @ 2014-06-20 18:49 UTC (permalink / raw)
To: rostedt, mingo, mgorman, akpm; +Cc: linux-kernel
The mm_migrate_pages trace event reports a reason for the migration, typically as a
symbolic string. The exception is the reason MR_NUMA_MISPLACED for which it just displays
the numeric value:
mm_migrate_pages: nr_succeeded=1 nr_failed=0 mode=MIGRATE_ASYNC reason=0x5
This patch makes the output consistent by introducing a string value for MR_NUMA_MISPLACED.
The event is then reported as:
mm_migrate_pages: nr_succeeded=1 nr_failed=0 mode=MIGRATE_ASYNC reason=numa_misplaced
Signed-off-by: Max Asbock <masbock@linux.vnet.ibm.com>
migrate.h | 1 +
1 file changed, 1 insertion(+)
--- linux-3.16-rc1/include/trace/events/migrate.h.orig 2014-06-20 10:00:26.768410407 -0700
+++ linux-3.16-rc1/include/trace/events/migrate.h 2014-06-20 10:01:55.432410334 -0700
@@ -17,6 +17,7 @@
{MR_MEMORY_HOTPLUG, "memory_hotplug"}, \
{MR_SYSCALL, "syscall_or_cpuset"}, \
{MR_MEMPOLICY_MBIND, "mempolicy_mbind"}, \
+ {MR_NUMA_MISPLACED, "numa_misplaced"}, \
{MR_CMA, "cma"}
TRACE_EVENT(mm_migrate_pages,
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Patch] tracing: tell mm_migrate_pages event about numa_misplaced
2014-06-20 18:49 [Patch] tracing: tell mm_migrate_pages event about numa_misplaced Max Asbock
@ 2014-06-23 14:21 ` Mel Gorman
2014-06-23 14:31 ` Steven Rostedt
0 siblings, 1 reply; 4+ messages in thread
From: Mel Gorman @ 2014-06-23 14:21 UTC (permalink / raw)
To: Max Asbock; +Cc: rostedt, mingo, akpm, linux-kernel
On Fri, Jun 20, 2014 at 11:49:16AM -0700, Max Asbock wrote:
>
> The mm_migrate_pages trace event reports a reason for the migration, typically as a
> symbolic string. The exception is the reason MR_NUMA_MISPLACED for which it just displays
> the numeric value:
> mm_migrate_pages: nr_succeeded=1 nr_failed=0 mode=MIGRATE_ASYNC reason=0x5
>
> This patch makes the output consistent by introducing a string value for MR_NUMA_MISPLACED.
> The event is then reported as:
> mm_migrate_pages: nr_succeeded=1 nr_failed=0 mode=MIGRATE_ASYNC reason=numa_misplaced
>
> Signed-off-by: Max Asbock <masbock@linux.vnet.ibm.com>
Acked-by: Mel Gorman <mgorman@suse.de>
--
Mel Gorman
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Patch] tracing: tell mm_migrate_pages event about numa_misplaced
2014-06-23 14:21 ` Mel Gorman
@ 2014-06-23 14:31 ` Steven Rostedt
2014-06-23 14:56 ` Mel Gorman
0 siblings, 1 reply; 4+ messages in thread
From: Steven Rostedt @ 2014-06-23 14:31 UTC (permalink / raw)
To: Mel Gorman; +Cc: Max Asbock, mingo, akpm, linux-kernel
On Mon, 23 Jun 2014 15:21:59 +0100
Mel Gorman <mgorman@suse.de> wrote:
> On Fri, Jun 20, 2014 at 11:49:16AM -0700, Max Asbock wrote:
> >
> > The mm_migrate_pages trace event reports a reason for the migration, typically as a
> > symbolic string. The exception is the reason MR_NUMA_MISPLACED for which it just displays
> > the numeric value:
> > mm_migrate_pages: nr_succeeded=1 nr_failed=0 mode=MIGRATE_ASYNC reason=0x5
> >
> > This patch makes the output consistent by introducing a string value for MR_NUMA_MISPLACED.
> > The event is then reported as:
> > mm_migrate_pages: nr_succeeded=1 nr_failed=0 mode=MIGRATE_ASYNC reason=numa_misplaced
> >
> > Signed-off-by: Max Asbock <masbock@linux.vnet.ibm.com>
>
> Acked-by: Mel Gorman <mgorman@suse.de>
>
Would you like to take this? Or Andrew?
You can add my Acked-by: Steven Rostedt <rostedt@goodmis.org>
-- Steve
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Patch] tracing: tell mm_migrate_pages event about numa_misplaced
2014-06-23 14:31 ` Steven Rostedt
@ 2014-06-23 14:56 ` Mel Gorman
0 siblings, 0 replies; 4+ messages in thread
From: Mel Gorman @ 2014-06-23 14:56 UTC (permalink / raw)
To: Steven Rostedt; +Cc: Max Asbock, mingo, akpm, linux-kernel
On Mon, Jun 23, 2014 at 10:31:11AM -0400, Steven Rostedt wrote:
> On Mon, 23 Jun 2014 15:21:59 +0100
> Mel Gorman <mgorman@suse.de> wrote:
>
> > On Fri, Jun 20, 2014 at 11:49:16AM -0700, Max Asbock wrote:
> > >
> > > The mm_migrate_pages trace event reports a reason for the migration, typically as a
> > > symbolic string. The exception is the reason MR_NUMA_MISPLACED for which it just displays
> > > the numeric value:
> > > mm_migrate_pages: nr_succeeded=1 nr_failed=0 mode=MIGRATE_ASYNC reason=0x5
> > >
> > > This patch makes the output consistent by introducing a string value for MR_NUMA_MISPLACED.
> > > The event is then reported as:
> > > mm_migrate_pages: nr_succeeded=1 nr_failed=0 mode=MIGRATE_ASYNC reason=numa_misplaced
> > >
> > > Signed-off-by: Max Asbock <masbock@linux.vnet.ibm.com>
> >
> > Acked-by: Mel Gorman <mgorman@suse.de>
> >
>
> Would you like to take this? Or Andrew?
>
I expect Andrew will pick it up.
--
Mel Gorman
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-06-23 14:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-20 18:49 [Patch] tracing: tell mm_migrate_pages event about numa_misplaced Max Asbock
2014-06-23 14:21 ` Mel Gorman
2014-06-23 14:31 ` Steven Rostedt
2014-06-23 14:56 ` Mel Gorman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox