Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

Wim Van Sebroeck
2014-06-23T21:23:24Z

Hi Alan,

> On Thu, 22 May 2014 22:34:44 +0200
> Maxime Ripard <maxime.ripard@free-electrons.com> wrote:
>
> > On Mon, May 19, 2014 at 05:04:22PM +0200, Maxime Ripard wrote:
> > > On Thu, May 15, 2014 at 11:11:23AM +0200, Maxime Ripard wrote:
> > > > On Wed, May 07, 2014 at 02:33:18PM -0700, Guenter Roeck wrote:
> > > > > On Tue, May 06, 2014 at 09:44:19PM -0500, Maxime Ripard wrote:
> > > > > > Most of the watchdog code is duplicated between the machine restart code and
> > > > > > the watchdog driver. Add the restart hook to the watchdog driver, to be able to
> > > > > > remove it from the machine code eventually.
> > > > > >
> > > > > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> > > > > > Acked-by: Arnd Bergmann <arnd@arndb.de>
> > > > >
> > > > > Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> > > >
> > > > Wim, do you have any comment on this one?
> > >
> > > Ping?
> > >
> > > It would be really great to see this in 3.16, and we get quite close
> > > to the end of ARM's merge window.
> >
> > Ping?
> >
> > Guenter, since you seem to be the only responsive, may I suggest that
> > you start merging patches and do a pull request to either Wim or Linus
> > directly during the merge window?
>
> I've yet to see anyone explain why this is an improvement over the
> current situation ?

To move forward: can you share your objections with us again?

Thanks,
Wim.