From: Jiri Olsa <jolsa@redhat.com>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Patrick Palka <patrick@parcs.ath.cx>,
linux-kernel@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@redhat.com>, Paul Mackerras <paulus@samba.org>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH -tip ] [BUGFIX]: Fix to add a missing pair of braces for error path.
Date: Tue, 24 Jun 2014 11:08:42 +0200 [thread overview]
Message-ID: <20140624090842.GA4091@krava.redhat.com> (raw)
In-Reply-To: <20140623031712.6541.39111.stgit@kbuild-fedora.novalocal>
On Mon, Jun 23, 2014 at 03:17:12AM +0000, Masami Hiramatsu wrote:
> Fix to add a missing pair of braces for error path.
> Commit 36d789a4d75f (perf probe: Improve error message for
> unknown member of data structure) introduced this bug.
>
> Without this fix, defining an event with global variables
> is always failed, because it always returns -ENOENT if
> the argument is not a local variable.
>
> ----
> # perf probe -na "vfs_read smp_found_config"
> Error: Failed to add events.
> ----
>
> With this fix, you can set a global variable for the
> argument of new event.
>
> ----
> # perf probe -na "vfs_read smp_found_config"
> Added new event:
> probe:vfs_read (on vfs_read with smp_found_config)
>
> You can now use it in all perf tools, such as:
>
> perf record -e probe:vfs_read -aR sleep 1
> ----
queued for perf/urgent
thanks,
jirka
next prev parent reply other threads:[~2014-06-24 9:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 7:13 [PATCH -tip 0/4] perf/probe: Improve error messages Masami Hiramatsu
2014-06-06 7:13 ` [PATCH -tip 1/4] perf/probe: Improve error message for unknown member of data structure Masami Hiramatsu
2014-06-12 12:04 ` [tip:perf/core] perf probe: " tip-bot for Masami Hiramatsu
2014-06-21 18:18 ` [PATCH -tip 1/4] perf/probe: " Patrick Palka
2014-06-23 2:21 ` Masami Hiramatsu
2014-06-23 3:17 ` [PATCH -tip ] [BUGFIX]: Fix to add a missing pair of braces for error path Masami Hiramatsu
2014-06-24 7:40 ` Namhyung Kim
2014-06-24 9:08 ` Jiri Olsa [this message]
2014-06-06 7:13 ` [PATCH -tip 2/4] perf/probe: Show error code and description in verbose mode Masami Hiramatsu
2014-06-12 12:04 ` [tip:perf/core] perf probe: " tip-bot for Masami Hiramatsu
2014-06-06 7:13 ` [PATCH -tip 3/4] perf/probe: Improve an error message of perf probe --vars mode Masami Hiramatsu
2014-06-12 12:04 ` [tip:perf/core] perf probe: " tip-bot for Masami Hiramatsu
2014-06-06 7:14 ` [PATCH -tip 4/4] perf/probe: Improve error messages with --line option Masami Hiramatsu
2014-06-10 8:11 ` Namhyung Kim
2014-06-10 10:26 ` Masami Hiramatsu
2014-06-12 12:04 ` [tip:perf/core] perf probe: Improve error messages in " tip-bot for Masami Hiramatsu
2014-06-06 13:08 ` [PATCH -tip 0/4] perf/probe: Improve error messages Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140624090842.GA4091@krava.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=patrick@parcs.ath.cx \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox