From: Lee Jones <lee.jones@linaro.org>
To: Sachin Kamat <sachin.kamat@samsung.com>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
davidb@codeaurora.org, spk.linux@gmail.com
Subject: Re: [PATCH 1/1] mfd: pm8921-core: Remove unused variable
Date: Tue, 24 Jun 2014 13:10:15 +0100 [thread overview]
Message-ID: <20140624121015.GL13803@lee--X1> (raw)
In-Reply-To: <1403600947-17790-1-git-send-email-sachin.kamat@samsung.com>
On Tue, 24 Jun 2014, Sachin Kamat wrote:
> ‘irq_bit’ is unused in the function. Remove it.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
> ---
> Compile tested.
> ---
> drivers/mfd/pm8921-core.c | 4 ----
> 1 file changed, 4 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/pm8921-core.c b/drivers/mfd/pm8921-core.c
> index 959513803542..39904f77c049 100644
> --- a/drivers/mfd/pm8921-core.c
> +++ b/drivers/mfd/pm8921-core.c
> @@ -186,11 +186,9 @@ static void pm8xxx_irq_mask_ack(struct irq_data *d)
> {
> struct pm_irq_chip *chip = irq_data_get_irq_chip_data(d);
> unsigned int pmirq = irqd_to_hwirq(d);
> - int irq_bit;
> u8 block, config;
>
> block = pmirq / 8;
> - irq_bit = pmirq % 8;
>
> config = chip->config[pmirq] | PM_IRQF_MASK_ALL | PM_IRQF_CLR;
> pm8xxx_config_irq(chip, block, config);
> @@ -200,11 +198,9 @@ static void pm8xxx_irq_unmask(struct irq_data *d)
> {
> struct pm_irq_chip *chip = irq_data_get_irq_chip_data(d);
> unsigned int pmirq = irqd_to_hwirq(d);
> - int irq_bit;
> u8 block, config;
>
> block = pmirq / 8;
> - irq_bit = pmirq % 8;
>
> config = chip->config[pmirq];
> pm8xxx_config_irq(chip, block, config);
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2014-06-24 12:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 9:09 [PATCH 1/1] mfd: pm8921-core: Remove unused variable Sachin Kamat
2014-06-24 12:10 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140624121015.GL13803@lee--X1 \
--to=lee.jones@linaro.org \
--cc=davidb@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sachin.kamat@samsung.com \
--cc=spk.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox