* [PATCH 1/1] mfd: pm8921-core: Remove unused variable
@ 2014-06-24 9:09 Sachin Kamat
2014-06-24 12:10 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Sachin Kamat @ 2014-06-24 9:09 UTC (permalink / raw)
To: linux-arm-msm, linux-kernel; +Cc: davidb, lee.jones, spk.linux
‘irq_bit’ is unused in the function. Remove it.
Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
---
Compile tested.
---
drivers/mfd/pm8921-core.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/mfd/pm8921-core.c b/drivers/mfd/pm8921-core.c
index 959513803542..39904f77c049 100644
--- a/drivers/mfd/pm8921-core.c
+++ b/drivers/mfd/pm8921-core.c
@@ -186,11 +186,9 @@ static void pm8xxx_irq_mask_ack(struct irq_data *d)
{
struct pm_irq_chip *chip = irq_data_get_irq_chip_data(d);
unsigned int pmirq = irqd_to_hwirq(d);
- int irq_bit;
u8 block, config;
block = pmirq / 8;
- irq_bit = pmirq % 8;
config = chip->config[pmirq] | PM_IRQF_MASK_ALL | PM_IRQF_CLR;
pm8xxx_config_irq(chip, block, config);
@@ -200,11 +198,9 @@ static void pm8xxx_irq_unmask(struct irq_data *d)
{
struct pm_irq_chip *chip = irq_data_get_irq_chip_data(d);
unsigned int pmirq = irqd_to_hwirq(d);
- int irq_bit;
u8 block, config;
block = pmirq / 8;
- irq_bit = pmirq % 8;
config = chip->config[pmirq];
pm8xxx_config_irq(chip, block, config);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] mfd: pm8921-core: Remove unused variable
2014-06-24 9:09 [PATCH 1/1] mfd: pm8921-core: Remove unused variable Sachin Kamat
@ 2014-06-24 12:10 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2014-06-24 12:10 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-arm-msm, linux-kernel, davidb, spk.linux
On Tue, 24 Jun 2014, Sachin Kamat wrote:
> ‘irq_bit’ is unused in the function. Remove it.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
> ---
> Compile tested.
> ---
> drivers/mfd/pm8921-core.c | 4 ----
> 1 file changed, 4 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/pm8921-core.c b/drivers/mfd/pm8921-core.c
> index 959513803542..39904f77c049 100644
> --- a/drivers/mfd/pm8921-core.c
> +++ b/drivers/mfd/pm8921-core.c
> @@ -186,11 +186,9 @@ static void pm8xxx_irq_mask_ack(struct irq_data *d)
> {
> struct pm_irq_chip *chip = irq_data_get_irq_chip_data(d);
> unsigned int pmirq = irqd_to_hwirq(d);
> - int irq_bit;
> u8 block, config;
>
> block = pmirq / 8;
> - irq_bit = pmirq % 8;
>
> config = chip->config[pmirq] | PM_IRQF_MASK_ALL | PM_IRQF_CLR;
> pm8xxx_config_irq(chip, block, config);
> @@ -200,11 +198,9 @@ static void pm8xxx_irq_unmask(struct irq_data *d)
> {
> struct pm_irq_chip *chip = irq_data_get_irq_chip_data(d);
> unsigned int pmirq = irqd_to_hwirq(d);
> - int irq_bit;
> u8 block, config;
>
> block = pmirq / 8;
> - irq_bit = pmirq % 8;
>
> config = chip->config[pmirq];
> pm8xxx_config_irq(chip, block, config);
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-24 12:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-24 9:09 [PATCH 1/1] mfd: pm8921-core: Remove unused variable Sachin Kamat
2014-06-24 12:10 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox