Re: [RESEND][PATCH 08/10][SCSI]mpt2sas: Get IOC_FACTS information using handshake protocol only after HBA card gets into READY or Operational state

Martin K. Petersen
2014-07-15T17:59:31Z

>>>>> "Sreekanth" == Reddy, Sreekanth <Sreekanth.Reddy@avagotech.com> writes:

Sreekanth> The driver would send IOC facts only if HBA is in operational
Sreekanth> or ready state. If it is in fault state, a diagnostic reset
Sreekanth> would be issued. It would wait for 10 seconds to exit out of
Sreekanth> reset state. If the HBA continues to be in reset state, then
Sreekanth> the HBA wouldn't be claimed by the driver.

Your patch header describes what used to happen. What does the patched
code do?

Also, several of your patches move large functions around within the
file. That makes it really hard to figure out what the actual code
changes are. Please split changes like that in two: One patch that moves
stuff around in bulk without any functional changes and a second that
addresses the issue at hand. That makes reviewing much easier.

--
Martin K. Petersen Oracle Linux Engineering