From: Tejun Heo <tj@kernel.org>
To: Benjamin LaHaise <bcrl@kvack.org>
Cc: cl@linux-foundation.org, kmo@daterainc.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] percpu-refcount, aio: use percpu_ref_cancel_init() in ioctx_alloc()
Date: Wed, 25 Jun 2014 10:56:34 -0400 [thread overview]
Message-ID: <20140625145634.GD26883@htj.dyndns.org> (raw)
In-Reply-To: <20140625143112.GR23137@kvack.org>
Hello, Benjamin.
On Wed, Jun 25, 2014 at 10:31:12AM -0400, Benjamin LaHaise wrote:
> On Tue, Jun 17, 2014 at 09:08:00PM -0400, Tejun Heo wrote:
> > ioctx_alloc() reaches inside percpu_ref and directly frees
> > ->pcpu_count in its failure path, which is quite gross. percpu_ref
> > has been providing a proper interface to do this,
> > percpu_ref_cancel_init(), for quite some time now. Let's use that
> > instead.
>
> I applied this to my aio-next tree at git://git.kvack.org/~bcrl/aio-next.git .
It'd probably easier if I route this through percpu tree with the rest
of changes as there are further changes on the aio side (trivial but
still), so we'd end up having to do pulling dance back and forth. The
changes on aio side are mostly trivial. Can I route them through
percpu tree with your acks?
Thanks.
--
tejun
next prev parent reply other threads:[~2014-06-25 14:56 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 1:07 [PATCHSET percpu/for-3.17] percpu: implement percpu_ref_reinit() Tejun Heo
2014-06-18 1:08 ` [PATCH 1/6] percpu-refcount, aio: use percpu_ref_cancel_init() in ioctx_alloc() Tejun Heo
2014-06-25 14:31 ` Benjamin LaHaise
2014-06-25 14:56 ` Tejun Heo [this message]
2014-06-25 15:35 ` Benjamin LaHaise
2014-06-25 15:37 ` Tejun Heo
2014-06-18 1:08 ` [PATCH 2/6] percpu-refcount: one bit is enough for REF_STATUS Tejun Heo
2014-06-18 2:37 ` Lai Jiangshan
2014-06-18 1:08 ` [PATCH 3/6] percpu-refcount: add helpers for ->percpu_count accesses Tejun Heo
2014-06-18 1:08 ` [PATCH 4/6] percpu-refcount: use unsigned long for pcpu_count pointer Tejun Heo
2014-06-18 1:08 ` [PATCH 5/6] percpu-refcount: require percpu_ref to be exited explicitly Tejun Heo
2014-06-18 1:08 ` [PATCH 6/6] percpu-refcount: implement percpu_ref_reinit() and percpu_ref_is_zero() Tejun Heo
2014-06-18 3:37 ` Lai Jiangshan
2014-06-18 15:32 ` Tejun Heo
2014-06-19 1:58 ` Lai Jiangshan
2014-06-19 2:07 ` Tejun Heo
2014-06-19 2:27 ` Paul E. McKenney
2014-06-19 13:36 ` Tejun Heo
2014-06-19 17:05 ` Paul E. McKenney
2014-06-19 19:06 ` Tejun Heo
2014-06-19 21:07 ` Paul E. McKenney
2014-06-19 2:20 ` [PATCH v2 " Tejun Heo
2014-06-19 3:01 ` Lai Jiangshan
2014-06-19 13:31 ` Tejun Heo
2014-06-19 16:55 ` Paul E. McKenney
2014-06-19 17:03 ` Paul E. McKenney
2014-06-19 19:06 ` Tejun Heo
2014-06-28 12:10 ` [PATCHSET percpu/for-3.17] percpu: implement percpu_ref_reinit() Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140625145634.GD26883@htj.dyndns.org \
--to=tj@kernel.org \
--cc=bcrl@kvack.org \
--cc=cl@linux-foundation.org \
--cc=kmo@daterainc.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox