Re: [hch-scsi-queue:core-for-3.17 18/27] drivers/staging/rts5208/rtsx.c:468:5: warning: format '%d' expects argument of type 'int', but argument 4 has type 'u64'

Re: [hch-scsi-queue:core-for-3.17 18/27] drivers/staging/rts5208/rtsx.c:468:5: warning: format '%d' expects argument of type 'int', but argument 4 has type 'u64'

[Christoph Hellwig]

Fengguang,

can you change the kbuild robot to only send warnings in the staging
drivers to the maintainers of those, and not people changing core code?

Re: [hch-scsi-queue:core-for-3.17 18/27] drivers/staging/rts5208/rtsx.c:468:5: warning: format '%d' expects argument of type 'int', but argument 4 has type 'u64'

[Fengguang Wu]

Hi Christoph,

On Wed, Jun 25, 2014 at 05:41:40PM +0200, Christoph Hellwig wrote:
> Fengguang,
> 
> can you change the kbuild robot to only send warnings in the staging
> drivers to the maintainers of those, and not people changing core code?

The rule is currently CC the first bad commit's author and committer.
In this case,

        commit 4184a1e415257e3d2e75a5adf184de9ffaf82a7c
        Author:     Hannes Reinecke <hare@suse.de>
        AuthorDate: Wed Jun 25 15:27:36 2014 +0200
        Commit:     Christoph Hellwig <hch@lst.de>
        CommitDate: Wed Jun 25 16:21:45 2014 +0200

            scsi: use 64-bit LUNs

=>

        TO: Hannes Reinecke <hare@suse.de>
        CC: Christoph Hellwig <hch@lst.de>

Do you mean adding rule

        if error_file =~ /drivers\/staging/
                TO/CC error_file's author/committer instead
        end

In this case,

        TO: Micky Ching <micky_ching@realsil.com.cn>
        CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

I agree that it'd be good for Micky to work out a fix for his staging
driver. However due to the obvious dependency here, it looks best for
you to include the fix together with "scsi: use 64-bit LUNs"?

So in general it'd be good to keep all relevant people in the CC list.
That is,

        TO/CC first bad commit's author/committer
        for each error_file =~ /drivers\/staging/
                CC error_file's author/committer
        end

Thanks,
Fengguang

Re: [hch-scsi-queue:core-for-3.17 18/27] drivers/staging/rts5208/rtsx.c:468:5: warning: format '%d' expects argument of type 'int', but argument 4 has type 'u64'

[Christoph Hellwig]

On Thu, Jun 26, 2014 at 12:23:22AM +0800, Fengguang Wu wrote:
> Do you mean adding rule
> 
>         if error_file =~ /drivers\/staging/
>                 TO/CC error_file's author/committer instead
>         end

Yes.

> I agree that it'd be good for Micky to work out a fix for his staging
> driver. However due to the obvious dependency here, it looks best for
> you to include the fix together with "scsi: use 64-bit LUNs"?

drivers/staging was only allowed in as long as it doesn't impact core
code and maintainers don't have to deal with the mess in there.  So
no drivers/staging/ changes should be burdened on core code.