From: "Theodore Ts'o" <tytso@mit.edu>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Jan Kara <jack@suse.cz>
Subject: Re: [PATCH 1/1] FS/JBD:replace count*size kmalloc by kmalloc_array
Date: Wed, 25 Jun 2014 21:17:51 -0400 [thread overview]
Message-ID: <20140626011751.GA6826@thunk.org> (raw)
In-Reply-To: <1403722146-19657-1-git-send-email-fabf@skynet.be>
On Wed, Jun 25, 2014 at 08:49:06PM +0200, Fabian Frederick wrote:
> kmalloc_array manages count*sizeof overflow.
Except in these call sites, overflow is impossible.
kmalloc_array() is useful when count is coming from an unvalidated
source. But in this case, the count is either a fixed, hard-coded
value (256), or the size of n*count is *guaranteed* to be less than
the page size.
So this just adds some extra code which is pointless (assuming the
compiler isn't smart enough to optimize it out).
- Ted
prev parent reply other threads:[~2014-06-26 1:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 18:49 [PATCH 1/1] FS/JBD:replace count*size kmalloc by kmalloc_array Fabian Frederick
2014-06-26 1:17 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140626011751.GA6826@thunk.org \
--to=tytso@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox