Re: [PATCH v3 3/3] sched: Rework check_for_tasks()

Srikar Dronamraju
2014-06-26T11:30:55Z

* Kirill Tkhai <ktkhai@parallels.com> [2014-06-25 12:19:55]:

>
> 1)Iterate thru all of threads in the system.
> Check for all threads, not only for group leaders.
>
> 2)Check for p->on_rq instead of p->state and cputime.
> Preempted task in !TASK_RUNNING state OR just
> created task may be queued, that we want to be
> reported too.
>
> 3)Use read_lock() instead of write_lock().
> This function does not change any structures, and
> read_lock() is enough.
>
> Signed-off-by: Kirill Tkhai <ktkhai@parallels.com>
> CC: Konstantin Khorenko <khorenko@parallels.com>
> CC: Ben Segall <bsegall@google.com>
> CC: Paul Turner <pjt@google.com>
> CC: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> CC: Mike Galbraith <umgwanakikbuti@gmail.com>
> CC: Peter Zijlstra <peterz@infradead.org>
> CC: Ingo Molnar <mingo@kernel.org>
> ---

Reviewed-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>

--
Thanks and Regards
Srikar Dronamraju