From: Greg KH <gregkh@linuxfoundation.org>
To: Thomas Vegas <thomas@grouk.net>
Cc: Larry.Finger@lwfinger.net, navin.patidar@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] staging: rtl8188eu: core: Remove unnecessary conditionals
Date: Thu, 26 Jun 2014 20:30:32 -0400 [thread overview]
Message-ID: <20140627003032.GA2944@kroah.com> (raw)
In-Reply-To: <1403434912-21655-1-git-send-email-thomas@grouk.net>
On Sun, Jun 22, 2014 at 01:01:50PM +0200, Thomas Vegas wrote:
> The variable 'pxmitbuf' is already set to NULL when entering the
> function. We can remove the first conditional. When _rtw_queue_empty()
> returns false, 'pxmitbuf' if not NULL. We can merge the second and
> third conditional.
>
> Signed-off-by: Thomas Vegas <thomas@grouk.net>
> ---
> drivers/staging/rtl8188eu/core/rtw_xmit.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
Due to changes by others in this file, your patches do not apply
anymore, sorry.
greg k-h
prev parent reply other threads:[~2014-06-27 4:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-22 11:01 [PATCH 1/3] staging: rtl8188eu: core: Remove unnecessary conditionals Thomas Vegas
2014-06-22 11:01 ` [PATCH 2/3] staging: rtl8188eu: core: Remove unnecessary parentheses Thomas Vegas
2014-06-22 11:01 ` [PATCH 3/3] staging: rtl8188eu: core: Remove extraneous blank lines Thomas Vegas
2014-06-27 0:30 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140627003032.GA2944@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=navin.patidar@gmail.com \
--cc=thomas@grouk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox