Re: [PATCH] mfd: cros_ec_spi: set wakeup capability

Olof Johansson
2014-06-27T00:28:46Z

On Mon, Jun 23, 2014 at 2:26 AM, Lee Jones <lee.jones@linaro.org> wrote:
>> Lee (-others),
>
> Re-CC'ing the list.
>
>> On Wed, Jun 18, 2014 at 2:20 AM, Lee Jones <lee.jones@linaro.org> wrote:
>> >> From: Prathyush K <prathyush.k@samsung.com>
>> >>
>> >> Set the device as wakeup capable and register the wakeup source.
>> >>
>> >> Note: Though it makes more sense to have the SPI framework do this,
>> >> (either via device tree or by board_info)
>> >> this change is as per an existing mail chain:
>> >> https://lkml.org/lkml/2009/8/27/291
>> >>
>> >> Signed-off-by: Prathyush K <prathyush.k@samsung.com>
>> >> Signed-off-by: Doug Anderson <dianders@chromium.org>
>> >> ---
>> >> Note that I don't have suspend/resume actually working upstream, but I
>> >> see that /sys/bus/spi/drivers/cros-ec-spi/spi2.0/power/wakeup exists
>> >> with this patch and doesn't exist without it.
>> >
>> > Very well. Applied, thanks.
>>
>> Thanks for applying! ...did this go in some non-standard branch? I
>> see another of my patches got committed to your "for-mfd-next" tree on
>> the 19th but I don't see this one...
>
> Patience Grasshopper. When I say that it's applied, it means that I
> have done so locally only. After I've collected a few local patches
> I'll usually then fix them all with with my SoB and push them out to
> the public MFD tree.
>
> BTW, it's always best to leave the ML in as CC, so others can see the
> answer to these types of questions. It may save a few emails a year,
> but every little helps. :)

It's great to see this on the list, because I find your workflow as a
maintainer to be hard to follow as a developer.

You applying patches but taking several days to push out makes it
completely opaque for someone to know if you just accidentally missed
to apply the patch after all (it happens, I've done that myself). It's
pretty common to expect a "thanks, applied" patch to show up in
linux-next within one day or so depending on timing.

The fact that you had already pushed out a patch that you had replied
to even later makes for extra confusion. So I'm sorry Lee, but I don't
think Doug was unreasonable in asking for status here. Sometimes
maintainers forget to push, which is why it's a good idea to ping a
few days later if the patch hasn't showed up in -next.

-Olof