From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753259AbaF0JKK (ORCPT ); Fri, 27 Jun 2014 05:10:10 -0400 Received: from mail-ig0-f171.google.com ([209.85.213.171]:55264 "EHLO mail-ig0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753227AbaF0JKE (ORCPT ); Fri, 27 Jun 2014 05:10:04 -0400 Date: Fri, 27 Jun 2014 10:09:58 +0100 From: Lee Jones To: Arnd Bergmann Cc: Jim Davis , sfr@canb.auug.org.au, linux-next , linux-kernel , sbkim73@samsung.com, sameo@linux.intel.com, grant.likely@linaro.org, robh+dt@kernel.org, devicetree Subject: Re: mfd: sec-core requires regulators Message-ID: <20140627090957.GG19645@lee--X1> References: <29237234.T7oGEGKuvp@wuerfel> <20140624154833.GR13803@lee--X1> <6906564.1ehoeq1QjB@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6906564.1ehoeq1QjB@wuerfel> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Jun 2014, Arnd Bergmann wrote: > The newly added sec-core mfd module calls the regulator_suspend_prepare() > function, which is only available if the regulator API is provided. This > matches the usage of the driver, so we can just add a Kconfig dependency. > > Reported-by: Jim Davis > Signed-off-by: Arnd Bergmann Thanks for re-sending Arnd, patch applied. > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 207c433..1caa3c5 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -582,7 +582,7 @@ config MFD_RC5T583 > > config MFD_SEC_CORE > bool "SAMSUNG Electronics PMIC Series Support" > - depends on I2C=y > + depends on I2C=y && REGULATOR > select MFD_CORE > select REGMAP_I2C > select REGMAP_IRQ -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog