From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Richard Leitner <richard.leitner@skidata.com>
Cc: Felipe Balbi <balbi@ti.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: serial: replace hardcoded ttyGS with PREFIX
Date: Fri, 27 Jun 2014 10:46:28 -0700 [thread overview]
Message-ID: <20140627174628.GA1449@kroah.com> (raw)
In-Reply-To: <20140627133721.10ca6cab@lxbuild.skidata.net>
On Fri, Jun 27, 2014 at 01:37:21PM +0200, Richard Leitner wrote:
> Replace all hardcoded ttyGS strings with the PREFIX macro.
Why?
> Therefore the PREFIX definition is moved to u_serial.h.
Why?
> Furthermore the modified files are checkpatch.pl compliant now.
You are doing two different things here in the same patch. Please split
it up into two different patches.
thanks,
greg k-h
next prev parent reply other threads:[~2014-06-27 17:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-27 11:37 [PATCH] usb: gadget: serial: replace hardcoded ttyGS with PREFIX Richard Leitner
2014-06-27 17:46 ` Greg Kroah-Hartman [this message]
2014-06-30 6:32 ` Richard Leitner
2014-06-30 8:36 ` [PATCHv2] " Richard Leitner
2014-06-30 8:41 ` David Laight
2014-06-30 8:56 ` Richard Leitner
2014-06-30 9:08 ` David Laight
2014-06-30 11:23 ` Richard Leitner
2014-06-30 14:45 ` Greg Kroah-Hartman
2014-07-01 7:31 ` Richard Leitner
2014-07-01 15:39 ` Richard Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140627174628.GA1449@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=balbi@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=richard.leitner@skidata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox