linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] cpufreq: make table sentinal macros unsigned to match use
@ 2014-06-27 21:09 Brian W Hart
  2014-06-28  0:18 ` Simon Horman
  2014-06-30  4:55 ` Viresh Kumar
  0 siblings, 2 replies; 6+ messages in thread
From: Brian W Hart @ 2014-06-27 21:09 UTC (permalink / raw)
  To: Rafael J. Wysocki, Viresh Kumar
  Cc: linux-kernel, linux-pm, linux-sh, Stratos Karafotis, Simon Horman,
	Magnus Damm

Commit 5eeaf1f18973 (cpufreq: Fix build error on some platforms that
use cpufreq_for_each_*) moved function cpufreq_next_valid() to a public
header.  Warnings are now generated when objects including that header
are built with -Wsign-compare (as an out-of-tree module might be):

.../include/linux/cpufreq.h: In function ‘cpufreq_next_valid’:
.../include/linux/cpufreq.h:519:27: warning: comparison between signed
and unsigned integer expressions [-Wsign-compare]
  while ((*pos)->frequency != CPUFREQ_TABLE_END)
                           ^
.../include/linux/cpufreq.h:520:25: warning: comparison between signed
and unsigned integer expressions [-Wsign-compare]
   if ((*pos)->frequency != CPUFREQ_ENTRY_INVALID)
                         ^

Constants CPUFREQ_ENTRY_INVALID and CPUFREQ_TABLE_END are signed, but
are used with unsigned member 'frequency' of cpufreq_frequency_table.
Update the macro definitions to be explicitly unsigned to match their
use.

This also corrects potentially wrong behavior of clk_rate_table_iter()
if unsigned long is wider than usigned int.

Signed-off-by: Brian W Hart <hartb@linux.vnet.ibm.com>
---
These macros are fairly broadly used in the kernel so I was bit leery
of changing them, but after inspection I think it's fine.  I found 102
uses of the macros, of which:

99 are uses with cpufreq_frequency_table.frequency (95) or with local
   variables of the same type as frequency (4).  These should be just
   fine with this change--we're just making explicit a conversion that
   was previously implicit.

 2 are uses with a local variable of different type (unsigned long) than
   'frequency' (in drivers/sh/clk/core.c).  One of these uses is safe;
   the other (in clk_rate_table_iter()) is broken if unsigned long
   is wider than unsigned int.  As a side-effect, this patch corrects
   the potential misbehavior there.

 1 is a use in macro cpufreq_for_each_entry() with what _should_ be the
   frequency member of a cpufreq_frequency_table, provided the caller it
   well-behaved.  There are 18 callers of this macro; all are well-behaved.
   So these should also be safe.

 include/linux/cpufreq.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
index ec4112d..8f8ae95 100644
--- a/include/linux/cpufreq.h
+++ b/include/linux/cpufreq.h
@@ -482,8 +482,8 @@ extern struct cpufreq_governor cpufreq_gov_conservative;
  *********************************************************************/
 
 /* Special Values of .frequency field */
-#define CPUFREQ_ENTRY_INVALID	~0
-#define CPUFREQ_TABLE_END	~1
+#define CPUFREQ_ENTRY_INVALID	~0u
+#define CPUFREQ_TABLE_END	~1u
 /* Special Values of .flags field */
 #define CPUFREQ_BOOST_FREQ	(1 << 0)
 
-- 
1.7.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] cpufreq: make table sentinal macros unsigned to match use
  2014-06-27 21:09 [PATCH] cpufreq: make table sentinal macros unsigned to match use Brian W Hart
@ 2014-06-28  0:18 ` Simon Horman
  2014-06-30  4:55 ` Viresh Kumar
  1 sibling, 0 replies; 6+ messages in thread
From: Simon Horman @ 2014-06-28  0:18 UTC (permalink / raw)
  To: Brian W Hart
  Cc: Rafael J. Wysocki, Viresh Kumar, linux-kernel, linux-pm, linux-sh,
	Stratos Karafotis, Magnus Damm

On Fri, Jun 27, 2014 at 04:09:39PM -0500, Brian W Hart wrote:
> Commit 5eeaf1f18973 (cpufreq: Fix build error on some platforms that
> use cpufreq_for_each_*) moved function cpufreq_next_valid() to a public
> header.  Warnings are now generated when objects including that header
> are built with -Wsign-compare (as an out-of-tree module might be):
> 
> .../include/linux/cpufreq.h: In function ‘cpufreq_next_valid’:
> .../include/linux/cpufreq.h:519:27: warning: comparison between signed
> and unsigned integer expressions [-Wsign-compare]
>   while ((*pos)->frequency != CPUFREQ_TABLE_END)
>                            ^
> .../include/linux/cpufreq.h:520:25: warning: comparison between signed
> and unsigned integer expressions [-Wsign-compare]
>    if ((*pos)->frequency != CPUFREQ_ENTRY_INVALID)
>                          ^
> 
> Constants CPUFREQ_ENTRY_INVALID and CPUFREQ_TABLE_END are signed, but
> are used with unsigned member 'frequency' of cpufreq_frequency_table.
> Update the macro definitions to be explicitly unsigned to match their
> use.
> 
> This also corrects potentially wrong behavior of clk_rate_table_iter()
> if unsigned long is wider than usigned int.
> 
> Signed-off-by: Brian W Hart <hartb@linux.vnet.ibm.com>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

> ---
> These macros are fairly broadly used in the kernel so I was bit leery
> of changing them, but after inspection I think it's fine.  I found 102
> uses of the macros, of which:
> 
> 99 are uses with cpufreq_frequency_table.frequency (95) or with local
>    variables of the same type as frequency (4).  These should be just
>    fine with this change--we're just making explicit a conversion that
>    was previously implicit.
> 
>  2 are uses with a local variable of different type (unsigned long) than
>    'frequency' (in drivers/sh/clk/core.c).  One of these uses is safe;
>    the other (in clk_rate_table_iter()) is broken if unsigned long
>    is wider than unsigned int.  As a side-effect, this patch corrects
>    the potential misbehavior there.
> 
>  1 is a use in macro cpufreq_for_each_entry() with what _should_ be the
>    frequency member of a cpufreq_frequency_table, provided the caller it
>    well-behaved.  There are 18 callers of this macro; all are well-behaved.
>    So these should also be safe.
> 
>  include/linux/cpufreq.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
> index ec4112d..8f8ae95 100644
> --- a/include/linux/cpufreq.h
> +++ b/include/linux/cpufreq.h
> @@ -482,8 +482,8 @@ extern struct cpufreq_governor cpufreq_gov_conservative;
>   *********************************************************************/
>  
>  /* Special Values of .frequency field */
> -#define CPUFREQ_ENTRY_INVALID	~0
> -#define CPUFREQ_TABLE_END	~1
> +#define CPUFREQ_ENTRY_INVALID	~0u
> +#define CPUFREQ_TABLE_END	~1u
>  /* Special Values of .flags field */
>  #define CPUFREQ_BOOST_FREQ	(1 << 0)
>  
> -- 
> 1.7.1
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] cpufreq: make table sentinal macros unsigned to match use
  2014-06-27 21:09 [PATCH] cpufreq: make table sentinal macros unsigned to match use Brian W Hart
  2014-06-28  0:18 ` Simon Horman
@ 2014-06-30  4:55 ` Viresh Kumar
  2014-07-11 22:06   ` Brian W Hart
  1 sibling, 1 reply; 6+ messages in thread
From: Viresh Kumar @ 2014-06-30  4:55 UTC (permalink / raw)
  To: Brian W Hart
  Cc: Rafael J. Wysocki, Linux Kernel Mailing List,
	linux-pm@vger.kernel.org, SH-Linux, Stratos Karafotis,
	Simon Horman, Magnus Damm

On 28 June 2014 02:39, Brian W Hart <hartb@linux.vnet.ibm.com> wrote:
> Commit 5eeaf1f18973 (cpufreq: Fix build error on some platforms that
> use cpufreq_for_each_*) moved function cpufreq_next_valid() to a public
> header.  Warnings are now generated when objects including that header
> are built with -Wsign-compare (as an out-of-tree module might be):
>
> .../include/linux/cpufreq.h: In function ‘cpufreq_next_valid’:
> .../include/linux/cpufreq.h:519:27: warning: comparison between signed
> and unsigned integer expressions [-Wsign-compare]
>   while ((*pos)->frequency != CPUFREQ_TABLE_END)
>                            ^
> .../include/linux/cpufreq.h:520:25: warning: comparison between signed
> and unsigned integer expressions [-Wsign-compare]
>    if ((*pos)->frequency != CPUFREQ_ENTRY_INVALID)
>                          ^
>
> Constants CPUFREQ_ENTRY_INVALID and CPUFREQ_TABLE_END are signed, but
> are used with unsigned member 'frequency' of cpufreq_frequency_table.
> Update the macro definitions to be explicitly unsigned to match their
> use.
>
> This also corrects potentially wrong behavior of clk_rate_table_iter()
> if unsigned long is wider than usigned int.
>
> Signed-off-by: Brian W Hart <hartb@linux.vnet.ibm.com>
> ---
> These macros are fairly broadly used in the kernel so I was bit leery
> of changing them, but after inspection I think it's fine.  I found 102
> uses of the macros, of which:
>
> 99 are uses with cpufreq_frequency_table.frequency (95) or with local
>    variables of the same type as frequency (4).  These should be just
>    fine with this change--we're just making explicit a conversion that
>    was previously implicit.
>
>  2 are uses with a local variable of different type (unsigned long) than
>    'frequency' (in drivers/sh/clk/core.c).  One of these uses is safe;
>    the other (in clk_rate_table_iter()) is broken if unsigned long
>    is wider than unsigned int.  As a side-effect, this patch corrects
>    the potential misbehavior there.
>
>  1 is a use in macro cpufreq_for_each_entry() with what _should_ be the
>    frequency member of a cpufreq_frequency_table, provided the caller it
>    well-behaved.  There are 18 callers of this macro; all are well-behaved.
>    So these should also be safe.

I would have moved some of it to logs, they look good.

>  include/linux/cpufreq.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
> index ec4112d..8f8ae95 100644
> --- a/include/linux/cpufreq.h
> +++ b/include/linux/cpufreq.h
> @@ -482,8 +482,8 @@ extern struct cpufreq_governor cpufreq_gov_conservative;
>   *********************************************************************/
>
>  /* Special Values of .frequency field */
> -#define CPUFREQ_ENTRY_INVALID  ~0
> -#define CPUFREQ_TABLE_END      ~1
> +#define CPUFREQ_ENTRY_INVALID  ~0u
> +#define CPUFREQ_TABLE_END      ~1u
>  /* Special Values of .flags field */
>  #define CPUFREQ_BOOST_FREQ     (1 << 0)

Thanks.

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] cpufreq: make table sentinal macros unsigned to match use
  2014-06-30  4:55 ` Viresh Kumar
@ 2014-07-11 22:06   ` Brian W Hart
  2014-07-18  1:20     ` Rafael J. Wysocki
  0 siblings, 1 reply; 6+ messages in thread
From: Brian W Hart @ 2014-07-11 22:06 UTC (permalink / raw)
  To: Viresh Kumar
  Cc: Rafael J. Wysocki, Linux Kernel Mailing List,
	linux-pm@vger.kernel.org, SH-Linux, Stratos Karafotis,
	Simon Horman, Magnus Damm

On Mon, Jun 30, 2014 at 10:25:20AM +0530, Viresh Kumar wrote:
> On 28 June 2014 02:39, Brian W Hart <hartb@linux.vnet.ibm.com> wrote:
> > Commit 5eeaf1f18973 (cpufreq: Fix build error on some platforms that
> > use cpufreq_for_each_*) moved function cpufreq_next_valid() to a public
> > header.  Warnings are now generated when objects including that header
> > are built with -Wsign-compare (as an out-of-tree module might be):
> >
> > .../include/linux/cpufreq.h: In function ‘cpufreq_next_valid’:
> > .../include/linux/cpufreq.h:519:27: warning: comparison between signed
> > and unsigned integer expressions [-Wsign-compare]
> >   while ((*pos)->frequency != CPUFREQ_TABLE_END)
> >                            ^
> > .../include/linux/cpufreq.h:520:25: warning: comparison between signed
> > and unsigned integer expressions [-Wsign-compare]
> >    if ((*pos)->frequency != CPUFREQ_ENTRY_INVALID)
> >                          ^
> >
> > Constants CPUFREQ_ENTRY_INVALID and CPUFREQ_TABLE_END are signed, but
> > are used with unsigned member 'frequency' of cpufreq_frequency_table.
> > Update the macro definitions to be explicitly unsigned to match their
> > use.
> >
> > This also corrects potentially wrong behavior of clk_rate_table_iter()
> > if unsigned long is wider than usigned int.
> >
> > Signed-off-by: Brian W Hart <hartb@linux.vnet.ibm.com>
> > ---
> > These macros are fairly broadly used in the kernel so I was bit leery
> > of changing them, but after inspection I think it's fine.  I found 102
> > uses of the macros, of which:
> >
> > 99 are uses with cpufreq_frequency_table.frequency (95) or with local
> >    variables of the same type as frequency (4).  These should be just
> >    fine with this change--we're just making explicit a conversion that
> >    was previously implicit.
> >
> >  2 are uses with a local variable of different type (unsigned long) than
> >    'frequency' (in drivers/sh/clk/core.c).  One of these uses is safe;
> >    the other (in clk_rate_table_iter()) is broken if unsigned long
> >    is wider than unsigned int.  As a side-effect, this patch corrects
> >    the potential misbehavior there.
> >
> >  1 is a use in macro cpufreq_for_each_entry() with what _should_ be the
> >    frequency member of a cpufreq_frequency_table, provided the caller it
> >    well-behaved.  There are 18 callers of this macro; all are well-behaved.
> >    So these should also be safe.
> 
> I would have moved some of it to logs, they look good.
> 
> >  include/linux/cpufreq.h |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
> > index ec4112d..8f8ae95 100644
> > --- a/include/linux/cpufreq.h
> > +++ b/include/linux/cpufreq.h
> > @@ -482,8 +482,8 @@ extern struct cpufreq_governor cpufreq_gov_conservative;
> >   *********************************************************************/
> >
> >  /* Special Values of .frequency field */
> > -#define CPUFREQ_ENTRY_INVALID  ~0
> > -#define CPUFREQ_TABLE_END      ~1
> > +#define CPUFREQ_ENTRY_INVALID  ~0u
> > +#define CPUFREQ_TABLE_END      ~1u
> >  /* Special Values of .flags field */
> >  #define CPUFREQ_BOOST_FREQ     (1 << 0)
> 
> Thanks.
> 
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

I haven't seen this appear in the linux-pm tree yet. Is there anything
further needed on my part--aside from patience?

Thank you,
brian


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] cpufreq: make table sentinal macros unsigned to match use
  2014-07-11 22:06   ` Brian W Hart
@ 2014-07-18  1:20     ` Rafael J. Wysocki
  2014-07-21 20:01       ` Brian W Hart
  0 siblings, 1 reply; 6+ messages in thread
From: Rafael J. Wysocki @ 2014-07-18  1:20 UTC (permalink / raw)
  To: Brian W Hart
  Cc: Viresh Kumar, Linux Kernel Mailing List, linux-pm@vger.kernel.org,
	SH-Linux, Stratos Karafotis, Simon Horman, Magnus Damm

On Friday, July 11, 2014 05:06:30 PM Brian W Hart wrote:
> On Mon, Jun 30, 2014 at 10:25:20AM +0530, Viresh Kumar wrote:
> > On 28 June 2014 02:39, Brian W Hart <hartb@linux.vnet.ibm.com> wrote:
> > > Commit 5eeaf1f18973 (cpufreq: Fix build error on some platforms that
> > > use cpufreq_for_each_*) moved function cpufreq_next_valid() to a public
> > > header.  Warnings are now generated when objects including that header
> > > are built with -Wsign-compare (as an out-of-tree module might be):
> > >
> > > .../include/linux/cpufreq.h: In function ‘cpufreq_next_valid’:
> > > .../include/linux/cpufreq.h:519:27: warning: comparison between signed
> > > and unsigned integer expressions [-Wsign-compare]
> > >   while ((*pos)->frequency != CPUFREQ_TABLE_END)
> > >                            ^
> > > .../include/linux/cpufreq.h:520:25: warning: comparison between signed
> > > and unsigned integer expressions [-Wsign-compare]
> > >    if ((*pos)->frequency != CPUFREQ_ENTRY_INVALID)
> > >                          ^
> > >
> > > Constants CPUFREQ_ENTRY_INVALID and CPUFREQ_TABLE_END are signed, but
> > > are used with unsigned member 'frequency' of cpufreq_frequency_table.
> > > Update the macro definitions to be explicitly unsigned to match their
> > > use.
> > >
> > > This also corrects potentially wrong behavior of clk_rate_table_iter()
> > > if unsigned long is wider than usigned int.
> > >
> > > Signed-off-by: Brian W Hart <hartb@linux.vnet.ibm.com>
> > > ---
> > > These macros are fairly broadly used in the kernel so I was bit leery
> > > of changing them, but after inspection I think it's fine.  I found 102
> > > uses of the macros, of which:
> > >
> > > 99 are uses with cpufreq_frequency_table.frequency (95) or with local
> > >    variables of the same type as frequency (4).  These should be just
> > >    fine with this change--we're just making explicit a conversion that
> > >    was previously implicit.
> > >
> > >  2 are uses with a local variable of different type (unsigned long) than
> > >    'frequency' (in drivers/sh/clk/core.c).  One of these uses is safe;
> > >    the other (in clk_rate_table_iter()) is broken if unsigned long
> > >    is wider than unsigned int.  As a side-effect, this patch corrects
> > >    the potential misbehavior there.
> > >
> > >  1 is a use in macro cpufreq_for_each_entry() with what _should_ be the
> > >    frequency member of a cpufreq_frequency_table, provided the caller it
> > >    well-behaved.  There are 18 callers of this macro; all are well-behaved.
> > >    So these should also be safe.
> > 
> > I would have moved some of it to logs, they look good.
> > 
> > >  include/linux/cpufreq.h |    4 ++--
> > >  1 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
> > > index ec4112d..8f8ae95 100644
> > > --- a/include/linux/cpufreq.h
> > > +++ b/include/linux/cpufreq.h
> > > @@ -482,8 +482,8 @@ extern struct cpufreq_governor cpufreq_gov_conservative;
> > >   *********************************************************************/
> > >
> > >  /* Special Values of .frequency field */
> > > -#define CPUFREQ_ENTRY_INVALID  ~0
> > > -#define CPUFREQ_TABLE_END      ~1
> > > +#define CPUFREQ_ENTRY_INVALID  ~0u
> > > +#define CPUFREQ_TABLE_END      ~1u
> > >  /* Special Values of .flags field */
> > >  #define CPUFREQ_BOOST_FREQ     (1 << 0)
> > 
> > Thanks.
> > 
> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> 
> I haven't seen this appear in the linux-pm tree yet. Is there anything
> further needed on my part--aside from patience?

Fell through the cracks, sorry.  I'll include this into the next PM pull request
for 3.16.  Thanks!

Rafael


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] cpufreq: make table sentinal macros unsigned to match use
  2014-07-18  1:20     ` Rafael J. Wysocki
@ 2014-07-21 20:01       ` Brian W Hart
  0 siblings, 0 replies; 6+ messages in thread
From: Brian W Hart @ 2014-07-21 20:01 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Viresh Kumar, Linux Kernel Mailing List, linux-pm@vger.kernel.org,
	SH-Linux, Stratos Karafotis, Simon Horman, Magnus Damm

On Fri, Jul 18, 2014 at 03:20:49AM +0200, Rafael J. Wysocki wrote:
> On Friday, July 11, 2014 05:06:30 PM Brian W Hart wrote:
> > On Mon, Jun 30, 2014 at 10:25:20AM +0530, Viresh Kumar wrote:
> > > On 28 June 2014 02:39, Brian W Hart <hartb@linux.vnet.ibm.com> wrote:
> > > > Commit 5eeaf1f18973 (cpufreq: Fix build error on some platforms that
> > > > use cpufreq_for_each_*) moved function cpufreq_next_valid() to a public
> > > > header.  Warnings are now generated when objects including that header
> > > > are built with -Wsign-compare (as an out-of-tree module might be):
> > > >
> > > > .../include/linux/cpufreq.h: In function ‘cpufreq_next_valid’:
> > > > .../include/linux/cpufreq.h:519:27: warning: comparison between signed
> > > > and unsigned integer expressions [-Wsign-compare]
> > > >   while ((*pos)->frequency != CPUFREQ_TABLE_END)
> > > >                            ^
> > > > .../include/linux/cpufreq.h:520:25: warning: comparison between signed
> > > > and unsigned integer expressions [-Wsign-compare]
> > > >    if ((*pos)->frequency != CPUFREQ_ENTRY_INVALID)
> > > >                          ^
> > > >
> > > > Constants CPUFREQ_ENTRY_INVALID and CPUFREQ_TABLE_END are signed, but
> > > > are used with unsigned member 'frequency' of cpufreq_frequency_table.
> > > > Update the macro definitions to be explicitly unsigned to match their
> > > > use.
> > > >
> > > > This also corrects potentially wrong behavior of clk_rate_table_iter()
> > > > if unsigned long is wider than usigned int.
> > > >
> > > > Signed-off-by: Brian W Hart <hartb@linux.vnet.ibm.com>
> > > > ---
> > > > These macros are fairly broadly used in the kernel so I was bit leery
> > > > of changing them, but after inspection I think it's fine.  I found 102
> > > > uses of the macros, of which:
> > > >
> > > > 99 are uses with cpufreq_frequency_table.frequency (95) or with local
> > > >    variables of the same type as frequency (4).  These should be just
> > > >    fine with this change--we're just making explicit a conversion that
> > > >    was previously implicit.
> > > >
> > > >  2 are uses with a local variable of different type (unsigned long) than
> > > >    'frequency' (in drivers/sh/clk/core.c).  One of these uses is safe;
> > > >    the other (in clk_rate_table_iter()) is broken if unsigned long
> > > >    is wider than unsigned int.  As a side-effect, this patch corrects
> > > >    the potential misbehavior there.
> > > >
> > > >  1 is a use in macro cpufreq_for_each_entry() with what _should_ be the
> > > >    frequency member of a cpufreq_frequency_table, provided the caller it
> > > >    well-behaved.  There are 18 callers of this macro; all are well-behaved.
> > > >    So these should also be safe.
> > > 
> > > I would have moved some of it to logs, they look good.
> > > 
> > > >  include/linux/cpufreq.h |    4 ++--
> > > >  1 files changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
> > > > index ec4112d..8f8ae95 100644
> > > > --- a/include/linux/cpufreq.h
> > > > +++ b/include/linux/cpufreq.h
> > > > @@ -482,8 +482,8 @@ extern struct cpufreq_governor cpufreq_gov_conservative;
> > > >   *********************************************************************/
> > > >
> > > >  /* Special Values of .frequency field */
> > > > -#define CPUFREQ_ENTRY_INVALID  ~0
> > > > -#define CPUFREQ_TABLE_END      ~1
> > > > +#define CPUFREQ_ENTRY_INVALID  ~0u
> > > > +#define CPUFREQ_TABLE_END      ~1u
> > > >  /* Special Values of .flags field */
> > > >  #define CPUFREQ_BOOST_FREQ     (1 << 0)
> > > 
> > > Thanks.
> > > 
> > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> > 
> > I haven't seen this appear in the linux-pm tree yet. Is there anything
> > further needed on my part--aside from patience?
> 
> Fell through the cracks, sorry.  I'll include this into the next PM pull request
> for 3.16.  Thanks!

Thank you!


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-07-21 20:01 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-27 21:09 [PATCH] cpufreq: make table sentinal macros unsigned to match use Brian W Hart
2014-06-28  0:18 ` Simon Horman
2014-06-30  4:55 ` Viresh Kumar
2014-07-11 22:06   ` Brian W Hart
2014-07-18  1:20     ` Rafael J. Wysocki
2014-07-21 20:01       ` Brian W Hart

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).