linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Weijie Yang <weijie.yang@samsung.com>,
	Jerome Marchand <jmarchan@redhat.com>,
	Nitin Gupta <ngupta@vflare.org>
Subject: Re: [PATCH 1/2] zram: use size_t instead of u16
Date: Mon, 30 Jun 2014 18:46:37 +0900	[thread overview]
Message-ID: <20140630094637.GA1055@swordfish> (raw)
In-Reply-To: <1404096879-24529-1-git-send-email-minchan@kernel.org>

On (06/30/14 11:54), Minchan Kim wrote:
> Date: Mon, 30 Jun 2014 11:54:38 +0900
> From: Minchan Kim <minchan@kernel.org>
> To: Andrew Morton <akpm@linux-foundation.org>
> Cc: linux-kernel@vger.kernel.org, Sergey Senozhatsky
>  <sergey.senozhatsky@gmail.com>, Weijie Yang <weijie.yang@samsung.com>,
>  Jerome Marchand <jmarchan@redhat.com>, Nitin Gupta <ngupta@vflare.org>,
>  Minchan Kim <minchan@kernel.org>
> Subject: [PATCH 1/2] zram: use size_t instead of u16
> X-Mailer: git-send-email 2.0.0
> 
> Some of arch(ex, hexagon and PowerPC) could use PAGE_SHIFT
> as 16 above. In the case, u16 is is lack of representing
> compressed page's size so use size_t.
> 
> Reported-by: Weijie Yang <weijie.yang@samsung.com>
> Signed-off-by: Minchan Kim <minchan@kernel.org>

Acked-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

	-ss

> ---
>  drivers/block/zram/zram_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
> index 089e72cd37be..3233bccd6361 100644
> --- a/drivers/block/zram/zram_drv.c
> +++ b/drivers/block/zram/zram_drv.c
> @@ -337,7 +337,7 @@ static int zram_decompress_page(struct zram *zram, char *mem, u32 index)
>  	unsigned char *cmem;
>  	struct zram_meta *meta = zram->meta;
>  	unsigned long handle;
> -	u16 size;
> +	size_t size;
>  
>  	read_lock(&meta->tb_lock);
>  	handle = meta->table[index].handle;
> -- 
> 2.0.0
> 

      parent reply	other threads:[~2014-06-30  9:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-30  2:54 [PATCH 1/2] zram: use size_t instead of u16 Minchan Kim
2014-06-30  2:54 ` [PATCH 2/2] zram: remove global tb_lock with fine grain lock Minchan Kim
2014-06-30  9:46 ` Sergey Senozhatsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140630094637.GA1055@swordfish \
    --to=sergey.senozhatsky@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=jmarchan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minchan@kernel.org \
    --cc=ngupta@vflare.org \
    --cc=weijie.yang@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).