public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Patrik Fimml <patrikf@chromium.org>
To: Dudley Du <dudl@cypress.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Alan Stern <stern@rowland.harvard.edu>,
	Benson Leung <bleung@google.com>, Lily Rui <lily@cypress.com>,
	Daniel Kurtz <djkurtz@google.com>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/14] input: cyapa: re-architecture driver to support multi-trackpads in one driver
Date: Mon, 30 Jun 2014 12:59:35 -0700	[thread overview]
Message-ID: <20140630195935.GA18256@google.com> (raw)
In-Reply-To: <77BC725C9062764F874D79F51E1F1A8F4C902B3B@S04-MBX01-01.s04.local>

Hi Dudley,

On Mon, Jun 30, 2014 at 05:43:06AM +0000, Dudley Du wrote:
> Attached are the patches files, I sent it firstly.

Thanks for the response, I was able to apply the patches now.

The attached files lack headers and commit messages though, so I don't have
fine-grained history in my git tree for convenient later review. The file names
suggest to me that you might just have copy-and-pasted the patches from
somewhere.

It would be great if you could attach them again in the format produced by "git
format-patch", with no further modifications done by hand. (If you feel the
need to do modifications, you should modify the actual commits e.g. with "git
rebase -i" before using format-patch.) Others can then simply import your
changes - including commit messages - into their tree with "git am".

Thanks,
Patrik

  reply	other threads:[~2014-06-30 19:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-27 23:49 [PATCH v2 0/14] input: cyapa: re-architecture driver to support multi-trackpads in one driver Patrik Fimml
2014-06-30  5:43 ` Dudley Du
2014-06-30 19:59   ` Patrik Fimml [this message]
2014-07-01  1:23     ` Dudley Du
2014-07-01  7:11     ` Dudley Du
2014-06-30  6:54 ` Dudley Du
  -- strict thread matches above, loose matches on Subject: below --
2014-06-30  6:40 Dudley Du
2014-06-06  7:28 Dudley Du

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140630195935.GA18256@google.com \
    --to=patrikf@chromium.org \
    --cc=bleung@google.com \
    --cc=djkurtz@google.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dudl@cypress.com \
    --cc=lily@cypress.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox