From: Mark Rutland <mark.rutland@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Dan Murphy <dmurphy@ti.com>,
"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2] ASoC: tas2552: Support TI TAS2552 Amplifier
Date: Tue, 1 Jul 2014 09:37:49 +0100 [thread overview]
Message-ID: <20140701083749.GH28740@leverpostej> (raw)
In-Reply-To: <20140630214342.GI23300@sirena.org.uk>
On Mon, Jun 30, 2014 at 10:43:42PM +0100, Mark Brown wrote:
> On Mon, Jun 30, 2014 at 06:21:15PM +0100, Mark Rutland wrote:
> > On Mon, Jun 30, 2014 at 06:10:59PM +0100, Dan Murphy wrote:
>
> > > +Optional properties:
>
> > > +- power-gpio - gpio pin to enable/disable the device
>
> > The code below seems to look for "enable-gpio". Searching for
> > "power-gpio" only hits in the line above and the example below. I assume
> > the code is in error?
>
> It depends what this is for - if it's for an external regulator it
> should be a regulator binding. Also all GPIO properties
> are supposed to be called -gpios because DT conventions.
Sure. I was commenting on the mismatch between "enable" in the code and
"power" in the documentation rather than the appropriateness of either
"power-gpios" or "enable-gpios".
Mark.
prev parent reply other threads:[~2014-07-01 8:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 17:10 [PATCH v2] ASoC: tas2552: Support TI TAS2552 Amplifier Dan Murphy
2014-06-30 17:21 ` Mark Rutland
2014-06-30 17:27 ` Dan Murphy
2014-06-30 21:43 ` Mark Brown
2014-07-01 8:37 ` Mark Rutland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140701083749.GH28740@leverpostej \
--to=mark.rutland@arm.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox