Re: [PATCH 2/2] ASoC: add driver for Rockchip RK3xxx I2S controller

[Mark Rutland <mark.rutland@arm.com>]

On Tue, Jul 01, 2014 at 09:47:38AM +0100, jianqun wrote:
> From: Jianqun Xu <xjq@rock-chips.com>
>
> Add driver for I2S controller in Rockchip RK3xxx SoCs.
>
> This driver patch has been tested on the RK3288 SDK board.
>
> Signed-off-by: Jianqun Xu <xjq@rock-chips.com>
> ---
>  sound/soc/Kconfig                 |    1 +
>  sound/soc/Makefile                |    1 +
>  sound/soc/rockchip/Kconfig        |   16 +
>  sound/soc/rockchip/Makefile       |    6 +
>  sound/soc/rockchip/i2s.h          |  222 +++++++++++++
>  sound/soc/rockchip/pcm.h          |   14 +
>  sound/soc/rockchip/rockchip_i2s.c |  622 +++++++++++++++++++++++++++++++++++++
>  sound/soc/rockchip/rockchip_pcm.c |   64 ++++
>  8 files changed, 946 insertions(+)
>  create mode 100644 sound/soc/rockchip/Kconfig
>  create mode 100644 sound/soc/rockchip/Makefile
>  create mode 100644 sound/soc/rockchip/i2s.h
>  create mode 100644 sound/soc/rockchip/pcm.h
>  create mode 100644 sound/soc/rockchip/rockchip_i2s.c
>  create mode 100644 sound/soc/rockchip/rockchip_pcm.c

[...]

> +static int rockchip_i2s_probe(struct platform_device *pdev)
> +{
> +       struct device_node *np = pdev->dev.of_node;
> +       struct rk_i2s_dev *i2s;
> +       struct resource *res;
> +       int ret;
> +
> +       i2s = devm_kzalloc(&pdev->dev, sizeof(struct rk_i2s_dev),
> +                               GFP_KERNEL);

You can use sizeof(*i2s) here.

[...]

> +       /* Try to set the I2S Channel id from dt */
> +       pdev->id = of_alias_get_id(np, "i2s");
> +       dev_set_name(&pdev->dev, "%s.%d",
> +                               pdev->dev.driver->name,
> +                               pdev->id);

This wasn't mentioned in the binding.

Cheers,
Mark.