From: Lee Jones <lee.jones@linaro.org>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: sbkim73@samsung.com, sameo@linux.intel.com, broonie@kernel.org,
myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv8 1/4] mfd: sec-core: Add support for S2MPU02 device
Date: Tue, 1 Jul 2014 15:00:04 +0100 [thread overview]
Message-ID: <20140701140004.GI27971@lee--X1> (raw)
In-Reply-To: <1403680487-12141-2-git-send-email-cw00.choi@samsung.com>
On Wed, 25 Jun 2014, Chanwoo Choi wrote:
> Add support for Samsung S2MPU02 PMIC device to the MFD sec-core driver.
> The S2MPU02 device includes PMIC/RTC/Clock devices.
>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> drivers/mfd/sec-core.c | 46 ++++++---
> drivers/mfd/sec-irq.c | 110 +++++++++++++++++---
> include/linux/mfd/samsung/core.h | 1 +
> include/linux/mfd/samsung/irq.h | 24 +++++
> include/linux/mfd/samsung/s2mpu02.h | 201 ++++++++++++++++++++++++++++++++++++
> 5 files changed, 352 insertions(+), 30 deletions(-)
> create mode 100644 include/linux/mfd/samsung/s2mpu02.h
I like what you've done, but really this patch should be split into 3
separate patches. One to consolidate the mfd_add_devices() calls, one
to consolidate the regmap_add_irq_chip() calls and the final one to
add support for the S2MPU02.
When you submit them, you can apply my:
Acked-by: Lee Jones <lee.jones@linaro.org>
... to each of them.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-07-01 14:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 7:14 [PATCHv8 0/4] mfd: sec-core: Add support S2MPU02 PMIC device Chanwoo Choi
2014-06-25 7:14 ` [PATCHv8 1/4] mfd: sec-core: Add support for S2MPU02 device Chanwoo Choi
2014-07-01 14:00 ` Lee Jones [this message]
2014-06-25 7:14 ` [PATCHv8 2/4] regulator: s2mps11: Add support S2MPU02 regulator device Chanwoo Choi
2014-07-01 14:02 ` Lee Jones
2014-06-25 7:14 ` [PATCHv8 3/4] dt-bindings: mfd: s2mps11: Add support S2MPU02 PMIC Chanwoo Choi
2014-06-25 7:14 ` [PATCHv8 4/4] mfd: sec-core: Prepare regulators for suspend state to reduce power-consumption Chanwoo Choi
2014-07-01 14:04 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140701140004.GI27971@lee--X1 \
--to=lee.jones@linaro.org \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=sameo@linux.intel.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox