From: Lee Jones <lee.jones@linaro.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Mark Brown <broonie@linaro.org>,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Carlo Caione <carlo@caione.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH resend v2 1/3] mfd-core: Don't register supplies from add_device, add register_supply_aliases()
Date: Tue, 1 Jul 2014 15:14:50 +0100 [thread overview]
Message-ID: <20140701141450.GL27971@lee--X1> (raw)
In-Reply-To: <53B2818F.8060705@redhat.com>
On Tue, 01 Jul 2014, Hans de Goede wrote:
> On 07/01/2014 11:22 AM, Lee Jones wrote:
> > On Mon, 30 Jun 2014, Hans de Goede wrote:
> >
> >> We cannot register supply alias in mfd_add_device before calling
> >> platform_add_device because platform-dev's name must be set before registering
> >> the aliases which happens from platform_add_device.
> >>
> >> So stop registering supply aliases from mfd_add_device, and add a
> >> mfd_register_supply_aliases helper functions for the cell's plaform driver
> >> probe method to use.
> >>
> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> >
> > Didn't I already Ack this?
>
> Ah yes you did, but back then I expected the series to get picked up
> immediately, so I did not add the ack to my local copy of it.
When resubmitting, it's always a good idea to look at previous review
in order to search for review comments to fix, or Acks to apply.
Unfortunately the set couldn't go in without Mark's review - which is
still the case.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-07-01 14:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 14:26 [PATCH resend v2 0/3] mfd-core: Don't register supplies from add_device, add register_supply_aliases() Hans de Goede
2014-06-30 14:26 ` [PATCH resend v2 1/3] " Hans de Goede
2014-07-01 9:22 ` Lee Jones
2014-07-01 9:38 ` Hans de Goede
2014-07-01 14:14 ` Lee Jones [this message]
2014-06-30 14:26 ` [PATCH resend v2 2/3] regulator/axp20x: Call mfd_register_supply_aliases Hans de Goede
2014-06-30 14:26 ` [PATCH resend v2 3/3] arizona-mfd-codecs: Add mfd_register_supply_aliases() calls Hans de Goede
2014-07-01 9:05 ` [PATCH resend v2 0/3] mfd-core: Don't register supplies from add_device, add register_supply_aliases() Lee Jones
2014-07-01 9:06 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140701141450.GL27971@lee--X1 \
--to=lee.jones@linaro.org \
--cc=broonie@linaro.org \
--cc=carlo@caione.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=hdegoede@redhat.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox