From: Oleg Nesterov <oleg@redhat.com>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Josh Triplett <josh@joshtriplett.org>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/2] rcu: uninline rcu_lock_acquire() and rcu_lock_release()
Date: Tue, 1 Jul 2014 16:55:23 +0200 [thread overview]
Message-ID: <20140701145523.GA12547@redhat.com> (raw)
In-Reply-To: <20140630202420.GG4603@linux.vnet.ibm.com>
On 06/30, Paul E. McKenney wrote:
>
> On Mon, Jun 30, 2014 at 06:18:37PM +0200, Oleg Nesterov wrote:
> > Hello,
> >
> > May be correct this time ;) Based on paulmck/linux-rcu.git rcu/next.
> >
> > 2/2 is new and hopefully trivial. But! the numbers look suspiciously
> > good, I do not understand where does the difference come from...
>
> Probably from rcu_dereference_raw() and rcu_dereference_check(..., 1). ;-)
Yes, sure, this was the motivation for the patch. But I didn't expect the
50k difference ;)
OK, I understand now. I forgot that every list_for_each_rcu/list_entry_rcu
has rcu_dereference_raw().
> Queued and kicked off testing, both mine and (indirectly) Fengguang's.
Thanks!
Oleg.
next prev parent reply other threads:[~2014-07-01 14:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 16:18 [PATCH v4 0/2] rcu: uninline rcu_lock_acquire() and rcu_lock_release() Oleg Nesterov
2014-06-30 16:18 ` [PATCH v4 1/2] " Oleg Nesterov
2014-07-01 11:41 ` Peter Zijlstra
2014-07-01 16:40 ` Oleg Nesterov
2014-07-08 22:22 ` Paul E. McKenney
2014-06-30 16:18 ` [PATCH v4 2/2] rcu: change rcu_dereference_check(c) to check "c" first Oleg Nesterov
2014-06-30 20:24 ` [PATCH v4 0/2] rcu: uninline rcu_lock_acquire() and rcu_lock_release() Paul E. McKenney
2014-07-01 14:55 ` Oleg Nesterov [this message]
2014-07-02 15:39 ` Oleg Nesterov
2014-07-02 18:59 ` [PATCH 0/1] rcu: uninline rcu_read_lock_held() Oleg Nesterov
2014-07-02 18:59 ` [PATCH 1/1] " Oleg Nesterov
2014-07-08 22:20 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140701145523.GA12547@redhat.com \
--to=oleg@redhat.com \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox