Re: [PATCH 49/50] mars: generic pre-patch for mars

Thomas Schöbel-Theuer
2014-07-02T14:46:12Z

> Using syscalls or syscall-like functionality from kernel code
> generally is a bad idea. Every single use needs a clear rationale in
> the patch description. Which do not seem to exist at all for the
> series, so in it's current form it'll go straight to the trash bin anyway.

Thanks, Christoph, for the explanation. I have been so long away from
the community that I don't remember all conventions / preferences any more.

Please, could you kindly advise me in the following dilemma:

Now there exists a vfs_rmdir() which I would gladly prefer in order to
avoid EXPORT_SYMBOL(sys_rmdir).

However, I probably would have to "borrow" large parts of the
sys_rmdir() implementation from fs/namei.c (the only real difference
appears to me that the pathname is not in userspace).

So, what is worse: copying relatively large pieces of code, or using
sys_rmdir()?

Thanks,

Thomas