Re: [PATCH 49/50] mars: generic pre-patch for mars

Christoph Hellwig
2014-07-03T10:41:27Z

Hi Thoams,

On Thu, Jul 03, 2014 at 08:10:33AM +0200, Thomas Sch?bel-Theuer wrote:
> I see the following alternative solutions for this:

All your alternatives really miss the point. I general we don't want
driver messing with the filesystem namespace, create their own symlink
farms or similar. Maybe there is a good explanation why your driver
is special, but you haven't provided it. In fact you've provided very
little explanation at all. You've submitted a series with a very
highlevel introduction, and the 50 patches with no explanation at all.

The exported syscalls where the first major issue to stick out, but
without even looking at the code I bet there will various other
roadblocks if someone actually bothers to review the rest of the code.

So before you come up with various take it or leave it alternatives I'd
suggest you figure out how

a) a driver submission should look like
b) explain and "sell" your design so that people get interested in it,
and will start to actually review it and discuss your design
tradeoffs with it.

An attitude of a few options to chose from isn't really going to get
your very far.