Re: [PATCH 49/50] mars: generic pre-patch for mars

Christoph Hellwig
2014-07-02T14:50:29Z

On Wed, Jul 02, 2014 at 04:36:42PM +0200, Thomas Sch?bel-Theuer wrote:
> However, I probably would have to "borrow" large parts of the
> sys_rmdir() implementation from fs/namei.c (the only real difference
> appears to me that the pathname is not in userspace).
>
> So, what is worse: copying relatively large pieces of code, or using
> sys_rmdir()?

Most likely you shouldn't do either. A block driver really should not
be removing directories from the filesystem namespace.