From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755715AbaGBQUz (ORCPT ); Wed, 2 Jul 2014 12:20:55 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33719 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751670AbaGBQUy (ORCPT ); Wed, 2 Jul 2014 12:20:54 -0400 Date: Wed, 2 Jul 2014 09:02:50 -0700 From: Greg Kroah-Hartman To: Rasmus Villemoes Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: arcnet: Remove "#define bool int" Message-ID: <20140702160250.GA2658@kroah.com> References: <1404303121-2548-1-git-send-email-linux@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1404303121-2548-1-git-send-email-linux@rasmusvillemoes.dk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 02, 2014 at 02:12:01PM +0200, Rasmus Villemoes wrote: > The header file include/linux/arcdevice.h #defines bool to int, if > bool is not already #defined. However, the files which use that header > file seem to rely on that #define (unconditionally) being in effect: > the prototypes for the functions arcrimi_reset, com20020_reset, > com90io_reset, com90xx_reset (whose addresses are assigned to the > hw.reset member of struct arcnet_local) use int explicitly. > > Moreover, that #define is an accident waiting to happen (scenario: > inclusion of arcdevice.h followed by inclusion of some header which > declares function prototypes using bool). Also, #include > must appear before #include (the > compiler wouldn't like "typedef _Bool int"). > > Since none of the files using arcdevice.h declare variables of type > "bool", the patch is actually quite simple, unlike the commit message. > > Signed-off-by: Rasmus Villemoes > --- > include/linux/arcdevice.h | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) Why are you sending this patch to me? I don't "own" it at all, please use scripts/get_maintainer.pl to determine who to email patches to. thanks, greg k-h