From: Borislav Petkov <bp@alien8.de>
To: Dave Hansen <dave@sr71.net>
Cc: x86@kernel.org, hpa@zytor.com, qiaowei.ren@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] x86: axe the lightly-used cpu_has_pae
Date: Wed, 2 Jul 2014 21:19:12 +0200 [thread overview]
Message-ID: <20140702191912.GJ1318@pd.tnic> (raw)
In-Reply-To: <20140702162926.3F2DAC08@viggo.jf.intel.com>
On Wed, Jul 02, 2014 at 09:29:26AM -0700, Dave Hansen wrote:
>
> From: Dave Hansen <dave.hansen@linux.intel.com>
>
> cpu_has_pae is only referenced in one place: the X86_32 kexec
> code (in a file not even built on 64-bit). It hardly warrants
> its own macro, or the trouble we go to ensuring that it can't
> be called in X86_64 code.
>
> Axe the macro and replace it with a direct cpu feature check.
>
> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Acked-by: Borislav Petkov <bp@suse.de>
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2014-07-02 19:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 16:29 [PATCH 0/4] [v3] x86 disabled features macros Dave Hansen
2014-07-02 16:29 ` [PATCH 1/4] x86: axe the lightly-used cpu_has_pae Dave Hansen
2014-07-02 19:19 ` Borislav Petkov [this message]
2014-07-02 16:29 ` [PATCH 2/4] x86: introduce disabled-features Dave Hansen
2014-07-02 19:27 ` Borislav Petkov
2014-07-02 16:29 ` [PATCH 3/4] x86: add more disabled features Dave Hansen
2014-07-02 19:34 ` Borislav Petkov
2014-07-02 16:29 ` [PATCH 4/4] x86: add MPX to disaabled features Dave Hansen
2014-07-02 19:43 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140702191912.GJ1318@pd.tnic \
--to=bp@alien8.de \
--cc=dave@sr71.net \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qiaowei.ren@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox