From: Wolfram Sang <wsa@the-dreams.de>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Rickard Strandqvist'" <rickard_strandqvist@spectrumdigital.se>,
"'Grant Likely'" <grant.likely@linaro.org>,
"'Rob Herring'" <robh+dt@kernel.org>,
"'Leilei Shang'" <shangll@marvell.com>,
"'Peter Korsgaard'" <peter@korsgaard.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2] i2c: busses: i2c-pxa.c: Fix for possible null pointer dereferenc
Date: Thu, 3 Jul 2014 10:41:09 +0200 [thread overview]
Message-ID: <20140703084108.GA3012@katana> (raw)
In-Reply-To: <003601cf9660$83368990$89a39cb0$%han@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 830 bytes --]
Hi Rickard, hi Jingoo,
> I also trust Wolfram. He is one of the most important and active
> person for Linux kernel.
Oh, thanks. I'm flattered :)
> Wolfram may mean devm_ioremap_resource(), not devm_ioremap().
Yes, you are right. Sorry for missing this detail when suggesting an
example to convert to devm_*. devm_ioremap_resource should be favoured
over devm_ioremap.
> 1. devm_ioremap_resource(): IS_ERR() can be used.
>
> dev->virtbase = devm_ioremap_resource(&adev->dev, res));
> if (IS_ERR(dev->virtbase)) {
This is correct and preferred.
BTW I don't care much about splitting up the patch as long as the commit
message says that the original bug is a motivation to swicth to devm_*.
Thanks Rickard for picking up the task, and thanks Jingoo for reviewing.
Kind regards,
Wolfram
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-07-03 8:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-29 23:28 [PATCH v2] i2c: busses: i2c-pxa.c: Fix for possible null pointer dereferenc Rickard Strandqvist
2014-06-29 23:28 ` Rickard Strandqvist
2014-06-30 0:05 ` Jingoo Han
2014-07-01 18:25 ` Rickard Strandqvist
2014-07-03 1:45 ` Jingoo Han
2014-07-03 8:41 ` Wolfram Sang [this message]
2014-07-03 19:46 ` Rickard Strandqvist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140703084108.GA3012@katana \
--to=wsa@the-dreams.de \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=jg1.han@samsung.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@korsgaard.com \
--cc=rickard_strandqvist@spectrumdigital.se \
--cc=robh+dt@kernel.org \
--cc=shangll@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox