Re: [RESEND PATCH 5/5] devicetree: mfd: max14577: Add device tree bindings document

Mark Rutland
2014-07-03T11:32:46Z

Hi,

On Tue, Jul 01, 2014 at 08:02:00AM +0100, Krzysztof Kozlowski wrote:
> Add document describing device tree bindings for MAX14577 MFD
> drivers: MFD core, extcon, regulator and charger.
>
> Both MAX14577 and MAX77836 chipsets are documented.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Tomasz Figa <t.figa@samsung.com>
> Cc: devicetree@vger.kernel.org
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
> Cc: Kumar Gala <galak@codeaurora.org>
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
> ---
> Documentation/devicetree/bindings/mfd/max14577.txt | 152 +++++++++++++++++++++
> 1 file changed, 152 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/max14577.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/max14577.txt b/Documentation/devicetree/bindings/mfd/max14577.txt
> new file mode 100644
> index 000000000000..b235250a7b41
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/max14577.txt
> @@ -0,0 +1,152 @@
> +Maxim MAX14577/77836 Multi-Function Device
> +
> +MAX14577 is a Multi-Function Device with Micro-USB Interface Circuit, Li+
> +Battery Charger and SFOUT LDO output for powering USB devices. It is
> +interfaced to host controller using I2C.
> +
> +MAX77836 additionally contains PMIC (with two LDO regulators) and Fuel Gauge.
> +
> +
> +Required properties:
> +- compatible : Must be "maxim,max14577" or "maxim,max77836".
> +- reg : I2C slave address for the max14577 chip (0x25 for max14577/max77836)
> +- interrupts : IRQ line for the chip.
> +- interrupt-parent : The parent interrupt controller.
> +
> +
> +Required nodes:
> + - charger :
> + Node for configuring the charger driver.
> + Required properties:
> + - compatible : "maxim,max14577-charger"
> + or "maxim,max77836-charger"
> + - maxim,fast-charge-timer : Timer in hours to trigger the
> + INT3/MBCCHGERR interrupt; Valid values:
> + - 5, 6 or 7 (hours),
> + - 0 to disable.

I'm not sure I follow what this is any why it should be in the DT.

Could you explain what this is used for?

Thanks,
Mark.