From: Tyler Hicks <tyhicks@canonical.com>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel@vger.kernel.org, ecryptfs@vger.kernel.org
Subject: Re: [PATCH 1/1] fs/ecryptfs/messaging.c: remove null test before kfree
Date: Thu, 3 Jul 2014 16:32:57 -0500 [thread overview]
Message-ID: <20140703213257.GA5089@boyd> (raw)
In-Reply-To: <1402941972-5166-1-git-send-email-fabf@skynet.be>
[-- Attachment #1: Type: text/plain, Size: 1312 bytes --]
On 2014-06-16 20:06:12, Fabian Frederick wrote:
> Fix checkpatch warning:
> WARNING: kfree(NULL) is safe this check is probably not required
>
> Cc: Tyler Hicks <tyhicks@canonical.com>
> Cc: ecryptfs@vger.kernel.org
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
Hi Fabian - Sorry for being slow to respond. This patch looks good. I'll
push it to my next branch.
Tyler
> fs/ecryptfs/messaging.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/ecryptfs/messaging.c b/fs/ecryptfs/messaging.c
> index e57380e..286f10b 100644
> --- a/fs/ecryptfs/messaging.c
> +++ b/fs/ecryptfs/messaging.c
> @@ -434,8 +434,7 @@ void ecryptfs_release_messaging(void)
> mutex_lock(&ecryptfs_msg_ctx_lists_mux);
> for (i = 0; i < ecryptfs_message_buf_len; i++) {
> mutex_lock(&ecryptfs_msg_ctx_arr[i].mux);
> - if (ecryptfs_msg_ctx_arr[i].msg)
> - kfree(ecryptfs_msg_ctx_arr[i].msg);
> + kfree(ecryptfs_msg_ctx_arr[i].msg);
> mutex_unlock(&ecryptfs_msg_ctx_arr[i].mux);
> }
> kfree(ecryptfs_msg_ctx_arr);
> --
> 1.8.4.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe ecryptfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-07-03 21:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 18:06 [PATCH 1/1] fs/ecryptfs/messaging.c: remove null test before kfree Fabian Frederick
2014-07-03 21:32 ` Tyler Hicks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140703213257.GA5089@boyd \
--to=tyhicks@canonical.com \
--cc=ecryptfs@vger.kernel.org \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox